Add support for element ids in TargetedStyleRecalc

Source/core/css/invalidation/StyleInvalidator.cpp

 
 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "core/css/invalidation/StyleInvalidator.h"
 
 #include "core/dom/Document.h"
@@ skipping 41 matching lines @@
     m_pendingInvalidationMap.clear();
 }
 
 StyleInvalidator::StyleInvalidator()
 { }
 
 void StyleInvalidator::RecursionData::pushInvalidationSet(const DescendantInvalidationSet& invalidationSet)
 {
     invalidationSet.getClasses(m_invalidationClasses);
     invalidationSet.getAttributes(m_invalidationAttributes);
+    invalidationSet.getIds(m_invalidationIds);
     m_foundInvalidationSet = true;
 }
 
 bool StyleInvalidator::RecursionData::matchesCurrentInvalidationSets(Element& element)
 {
     if (element.hasClass()) {
         const SpaceSplitString& classNames = element.classNames();
         for (Vector<AtomicString>::const_iterator it = m_invalidationClasses.begin(); it != m_invalidationClasses.end(); ++it) {
             if (classNames.contains(*it))
                 return true;
         }
     }
     if (element.hasAttributes()) {
         for (Vector<AtomicString>::const_iterator it = m_invalidationAttributes.begin(); it != m_invalidationAttributes.end(); ++it) {
             if (element.hasAttribute(*it))
                 return true;
         }
     }
-
+    if (element.hasID()) {
+        const AtomicString& id = element.idForStyleResolution();
+        for (Vector<AtomicString>::const_iterator it = m_invalidationIds.begin(); it != m_invalidationIds.end(); ++it) {
+            if (id == *it)

[esprehn, 2014/04/01 23:11:19]

You don't need this loop,

if (m_invalidationIds.contains(element.idForStyleResolution()))
  return true;

[chrishtr, 2014/04/01 23:20:08]

Good point! Fixed.

+                return true;
+        }
+    }
     return false;
 }
 
 bool StyleInvalidator::checkInvalidationSetsAgainstElement(Element& element)
 {
     bool thisElementNeedsStyleRecalc = false;
     if (element.needsStyleInvalidation()) {
         if (InvalidationList* invalidationList = m_pendingInvalidationMap.get(&element)) {
             // FIXME: it's really only necessary to clone the render style for this element, not full style recalc.
             thisElementNeedsStyleRecalc = true;
@@ skipping 57 matching lines @@
         }
     }
 
     element.clearChildNeedsStyleInvalidation();
     element.clearNeedsStyleInvalidation();
 
     return thisElementNeedsStyleRecalc;
 }
 
 } // namespace WebCore