Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden

Issue 2201193004: Use Variable::binding_needs_init() to determine hole initialization (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove one more comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden ('k') | test/cctest/interpreter/bytecode_expectations/NewTarget.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden b/test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
index 1092d91baf481f6e6f84d8a18175bb9b37b3941e..62aadef81133931012dbb8fbf647291463dc2217 100644
--- a/test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
+++ b/test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
@@ -22,33 +22,25 @@ snippet: "
test();
})();
"
-frame size: 7
+frame size: 6
parameter count: 1
-bytecode array length: 53
+bytecode array length: 35
bytecodes: [
B(Mov), R(closure), R(0),
/* 99 E> */ B(StackCheck),
- /* 104 S> */ B(Mov), R(this), R(3),
- B(Ldar), R(closure),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(0),
- B(Star), R(6),
- /* 111 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(6), U8(1),
- B(Star), R(6),
+ /* 104 S> */ B(LdaConstant), U8(0),
+ /* 111 E> */ B(LdrKeyedProperty), R(closure), U8(3), R(4),
B(LdaConstant), U8(1),
- /* 111 E> */ B(LdrKeyedProperty), R(6), U8(3), R(4),
- B(LdaConstant), U8(2),
B(Star), R(5),
+ B(Mov), R(this), R(3),
B(CallRuntime), U16(Runtime::kLoadFromSuper), R(3), U8(3),
- B(Mov), R(3), R(2),
B(Star), R(1),
- /* 117 E> */ B(Call), R(1), R(2), U8(1), U8(1),
+ /* 117 E> */ B(Call), R(1), R(this), U8(1), U8(1),
B(Star), R(3),
B(AddSmi), U8(1), R(3),
/* 131 S> */ B(Return),
]
constant pool: [
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::SYMBOL_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
@@ -70,42 +62,29 @@ snippet: "
test();
})();
"
-frame size: 6
+frame size: 5
parameter count: 1
-bytecode array length: 75
+bytecode array length: 45
bytecodes: [
B(Mov), R(closure), R(0),
/* 125 E> */ B(StackCheck),
- /* 130 S> */ B(Mov), R(this), R(1),
- B(Ldar), R(closure),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(0),
- B(Star), R(5),
- /* 130 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(5), U8(1),
- B(Star), R(5),
+ /* 130 S> */ B(LdaConstant), U8(0),
+ /* 130 E> */ B(LdrKeyedProperty), R(closure), U8(1), R(2),
B(LdaConstant), U8(1),
- /* 130 E> */ B(LdrKeyedProperty), R(5), U8(1), R(2),
- B(LdaConstant), U8(2),
B(Star), R(3),
B(LdaSmi), U8(2),
B(Star), R(4),
+ B(Mov), R(this), R(1),
/* 138 E> */ B(CallRuntime), U16(Runtime::kStoreToSuper_Strict), R(1), U8(4),
- /* 143 S> */ B(Mov), R(this), R(1),
- B(Ldar), R(0),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(0),
- B(Star), R(4),
- /* 150 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
- B(Star), R(4),
+ /* 143 S> */ B(LdaConstant), U8(0),
+ /* 150 E> */ B(LdrKeyedProperty), R(closure), U8(3), R(2),
B(LdaConstant), U8(1),
- /* 150 E> */ B(LdrKeyedProperty), R(4), U8(3), R(2),
- B(LdaConstant), U8(2),
B(Star), R(3),
+ B(Mov), R(this), R(1),
B(CallRuntime), U16(Runtime::kLoadFromSuper), R(1), U8(3),
/* 159 S> */ B(Return),
]
constant pool: [
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::SYMBOL_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
@@ -125,48 +104,38 @@ snippet: "
test = new B().constructor;
})();
"
-frame size: 5
+frame size: 4
parameter count: 1
-bytecode array length: 105
+bytecode array length: 79
bytecodes: [
B(Mov), R(closure), R(1),
B(Mov), R(new_target), R(0),
/* 113 E> */ B(StackCheck),
- /* 118 S> */ B(Ldar), R(closure),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(0),
- B(Star), R(3),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
- B(Star), R(2),
- B(CallRuntime), U16(Runtime::k_GetSuperConstructor), R(2), U8(1),
+ /* 118 S> */ B(CallRuntime), U16(Runtime::k_GetSuperConstructor), R(closure), U8(1),
B(Star), R(2),
B(LdaSmi), U8(1),
B(Star), R(3),
- B(Ldar), R(0),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(1),
- B(Star), R(4),
- /* 118 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
+ B(Ldar), R(new_target),
/* 118 E> */ B(New), R(2), R(3), U8(1),
B(Star), R(2),
B(Ldar), R(this),
B(JumpIfNotHole), U8(4),
B(Jump), U8(11),
- B(LdaConstant), U8(2),
+ B(LdaConstant), U8(0),
B(Star), R(3),
/* 118 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
B(Mov), R(2), R(this),
/* 128 S> */ B(Ldar), R(this),
B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(2),
+ B(LdaConstant), U8(0),
B(Star), R(2),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1),
B(Star), R(2),
B(LdaSmi), U8(2),
- /* 136 E> */ B(StaNamedPropertyStrict), R(2), U8(3), U8(4),
+ /* 136 E> */ B(StaNamedPropertyStrict), R(2), U8(1), U8(4),
B(Ldar), R(this),
B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(2),
+ B(LdaConstant), U8(0),
B(Star), R(2),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1),
/* 141 S> */ B(Return),
@@ -174,8 +143,6 @@ bytecodes: [
constant pool: [
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
]
@@ -195,44 +162,34 @@ snippet: "
"
frame size: 4
parameter count: 1
-bytecode array length: 101
+bytecode array length: 75
bytecodes: [
B(Mov), R(closure), R(1),
B(Mov), R(new_target), R(0),
/* 112 E> */ B(StackCheck),
- /* 117 S> */ B(Ldar), R(closure),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(0),
- B(Star), R(3),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
- B(Star), R(2),
- B(CallRuntime), U16(Runtime::k_GetSuperConstructor), R(2), U8(1),
+ /* 117 S> */ B(CallRuntime), U16(Runtime::k_GetSuperConstructor), R(closure), U8(1),
B(Star), R(2),
- B(Ldar), R(0),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(1),
- B(Star), R(3),
- /* 117 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
+ B(Ldar), R(new_target),
/* 117 E> */ B(New), R(2), R(0), U8(0),
B(Star), R(2),
B(Ldar), R(this),
B(JumpIfNotHole), U8(4),
B(Jump), U8(11),
- B(LdaConstant), U8(2),
+ B(LdaConstant), U8(0),
B(Star), R(3),
/* 117 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
B(Mov), R(2), R(this),
/* 126 S> */ B(Ldar), R(this),
B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(2),
+ B(LdaConstant), U8(0),
B(Star), R(2),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1),
B(Star), R(2),
B(LdaSmi), U8(2),
- /* 134 E> */ B(StaNamedPropertyStrict), R(2), U8(3), U8(4),
+ /* 134 E> */ B(StaNamedPropertyStrict), R(2), U8(1), U8(4),
B(Ldar), R(this),
B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(2),
+ B(LdaConstant), U8(0),
B(Star), R(2),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(2), U8(1),
/* 139 S> */ B(Return),
@@ -240,8 +197,6 @@ bytecodes: [
constant pool: [
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
]
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden ('k') | test/cctest/interpreter/bytecode_expectations/NewTarget.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698