Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden

Issue 2201193004: Use Variable::binding_needs_init() to determine hole initialization (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove one more comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden b/test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden
index ac37cd37c2894d0b74379981aa57593eb209b6c0..30126619390a35188e0db74851f3c21c97a522ab 100644
--- a/test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden
+++ b/test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden
@@ -103,7 +103,7 @@ snippet: "
"
frame size: 5
parameter count: 1
-bytecode array length: 50
+bytecode array length: 40
bytecodes: [
/* 30 E> */ B(StackCheck),
B(LdaConstant), U8(0),
@@ -117,12 +117,8 @@ bytecodes: [
B(Star), R(0),
/* 53 S> */ B(LdaSmi), U8(10),
/* 53 E> */ B(StaContextSlot), R(context), U8(4),
+ B(Mov), R(0), R(1),
B(Ldar), R(0),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(2),
- B(Star), R(3),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
- B(Star), R(1),
/* 88 S> */ B(Jump), U8(2),
B(PopContext), R(2),
B(LdaUndefined),
@@ -131,7 +127,6 @@ bytecodes: [
constant pool: [
InstanceType::FIXED_ARRAY_TYPE,
InstanceType::SHARED_FUNCTION_INFO_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
]
@@ -151,7 +146,7 @@ snippet: "
"
frame size: 6
parameter count: 1
-bytecode array length: 127
+bytecode array length: 115
bytecodes: [
B(CreateFunctionContext), U8(1),
B(PushContext), R(2),
@@ -171,15 +166,10 @@ bytecodes: [
B(Star), R(0),
/* 76 S> */ B(LdaSmi), U8(2),
/* 76 E> */ B(StaContextSlot), R(context), U8(4),
- B(Ldar), R(0),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(2),
- B(Star), R(4),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
- B(Star), R(1),
+ B(Mov), R(0), R(1),
/* 118 S> */ B(LdaContextSlot), R(context), U8(4),
B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(3),
+ B(LdaConstant), U8(2),
B(Star), R(4),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
B(JumpIfToBooleanFalse), U8(6),
@@ -189,7 +179,7 @@ bytecodes: [
B(Star), R(4),
/* 144 E> */ B(LdaContextSlot), R(context), U8(4),
B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(3),
+ B(LdaConstant), U8(2),
B(Star), R(5),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(5), U8(1),
B(Ldar), R(4),
@@ -199,7 +189,7 @@ bytecodes: [
B(Star), R(4),
/* 157 E> */ B(LdaContextSlot), R(context), U8(4),
B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(4),
+ B(LdaConstant), U8(3),
B(Star), R(5),
B(CallRuntime), U16(Runtime::kThrowReferenceError), R(5), U8(1),
B(Ldar), R(4),
@@ -212,7 +202,6 @@ constant pool: [
InstanceType::SHARED_FUNCTION_INFO_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
- InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
]

Powered by Google App Engine
This is Rietveld 408576698