Implement GPU occluded blur mask filter

Implement GPU occluded blur mask filter

Spawned off:
https://codereview.chromium.org/2214163003/ (Minor clean up related to blur mask filters)
https://codereview.chromium.org/2232263002/ (Always give simple circular rrects a shot at being directly blurred on the GPU)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002

Committed: https://skia.googlesource.com/skia/+/27cdd947903a4262bb483e7d35153358f4541bf8

[robertphillips, 2016-08-02 17:42:44]

Description was changed from

==========
Implement GPU occluded blur mask filter
==========

to

==========
Implement GPU occluded blur mask filter
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
==========

[robertphillips, 2016-08-02 17:43:34]

Description was changed from

==========
Implement GPU occluded blur mask filter
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
==========

to

==========
Implement GPU occluded blur mask filter

This is dependent upon: https://codereview.chromium.org/2201993003/ (Add GM to
test out blurmaskfilter occluders)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
==========

[robertphillips, 2016-08-02 17:43:34]

robertphillips@google.com changed reviewers:
+ reed@google.com

[robertphillips, 2016-08-04 14:43:29]

robertphillips@google.com changed reviewers:
+ jvanverth@google.com

[robertphillips, 2016-08-04 20:22:29]

Description was changed from

==========
Implement GPU occluded blur mask filter

This is dependent upon: https://codereview.chromium.org/2201993003/ (Add GM to
test out blurmaskfilter occluders)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
==========

to

==========
Implement GPU occluded blur mask filter

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
==========

[robertphillips, 2016-08-04 20:25:48]

Patchset #3 (id:40001) has been deleted

[robertphillips, 2016-08-04 20:39:16]

Patchset #3 (id:60001) has been deleted

[robertphillips, 2016-08-04 20:55:22]

Description was changed from

==========
Implement GPU occluded blur mask filter

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
==========

to

==========
Implement GPU occluded blur mask filter

Spawned off: https://codereview.chromium.org/2214163003/ (Minor clean up related
to blur mask filters)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
==========

[robertphillips, 2016-08-09 13:54:09]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-08-09 13:54:09]

ping

[reed1, 2016-08-09 14:04:54]

https://codereview.chromium.org/2201133002/diff/100001/src/effects/SkBlurMask...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/2201133002/diff/100001/src/effects/SkBlurMask...
src/effects/SkBlurMaskFilter.cpp:155: fOccluder.sort();
Lets do this (or reject it) in the factory, rather than here in the
constructor....

[bsalomon, 2016-08-09 14:05:57]

lgtm

https://codereview.chromium.org/2201133002/diff/100001/src/effects/SkBlurMask...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/2201133002/diff/100001/src/effects/SkBlurMask...
src/effects/SkBlurMaskFilter.cpp:1178: static void to_points(const SkRect& r,
SkPoint* points) {
SkRect::toQuad?

[robertphillips, 2016-08-09 14:46:35]

https://codereview.chromium.org/2201133002/diff/100001/src/effects/SkBlurMask...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/2201133002/diff/100001/src/effects/SkBlurMask...
src/effects/SkBlurMaskFilter.cpp:155: fOccluder.sort();
On 2016/08/09 14:04:54, reed1 wrote:
> Lets do this (or reject it) in the factory, rather than here in the
> constructor....

Done. If the user passes in an inverted rect it will just be ignored as empty.

https://codereview.chromium.org/2201133002/diff/100001/src/effects/SkBlurMask...
src/effects/SkBlurMaskFilter.cpp:1178: static void to_points(const SkRect& r,
SkPoint* points) {
On 2016/08/09 14:05:56, bsalomon wrote:
> SkRect::toQuad?

Done.

[reed1, 2016-08-09 15:06:09]

I still hate the API

lgtm

[robertphillips, 2016-08-09 16:16:01]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 16:16:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 16:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 16:49:26]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-10 19:13:54]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 19:14:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 19:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 19:43:54]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-08-10 22:09:46]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-08-10 22:09:47]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/2201133002/#ps140001
(title: "update to ToT")

[commit-bot: I haz the power, 2016-08-10 22:09:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:25:28]

Description was changed from

==========
Implement GPU occluded blur mask filter

Spawned off: https://codereview.chromium.org/2214163003/ (Minor clean up related
to blur mask filters)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002
==========

to

==========
Implement GPU occluded blur mask filter

Spawned off: https://codereview.chromium.org/2214163003/ (Minor clean up related
to blur mask filters)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002

Committed:
https://skia.googlesource.com/skia/+/27cdd947903a4262bb483e7d35153358f4541bf8
==========

[commit-bot: I haz the power, 2016-08-10 23:25:30]

Committed patchset #6 (id:140001) as
https://skia.googlesource.com/skia/+/27cdd947903a4262bb483e7d35153358f4541bf8

[robertphillips, 2016-08-11 14:33:17]

Description was changed from

==========
Implement GPU occluded blur mask filter

Spawned off: https://codereview.chromium.org/2214163003/ (Minor clean up related
to blur mask filters)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002

Committed:
https://skia.googlesource.com/skia/+/27cdd947903a4262bb483e7d35153358f4541bf8
==========

to

==========
Implement GPU occluded blur mask filter

Spawned off:
https://codereview.chromium.org/2214163003/ (Minor clean up related to blur mask
filters)
https://codereview.chromium.org/2232263002/ (Always give simple circular rrects
a shot at being directly blurred on the GPU)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201133002

Committed:
https://skia.googlesource.com/skia/+/27cdd947903a4262bb483e7d35153358f4541bf8
==========