src/compiler/verifier.cc - Issue 2201073002: [turbofan] Adds speculative operator for bitwise and, or and xor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/verifier.cc

Issue 2201073002: [turbofan] Adds speculative operator for bitwise and, or and xor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Handles kSigned32 feedback. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/verifier.cc

diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc

index a41916eaee9eafd8dc1273fef57cad1a4a940ad3..3375d410fd81120c6770339165be43771b0984cc 100644

--- a/src/compiler/verifier.cc

+++ b/src/compiler/verifier.cc

@@ -712,6 +712,11 @@ void Verifier::Visitor::Check(Node* node) {

CheckValueInputIs(node, 1, Type::Signed32());

CheckUpperIs(node, Type::Signed32());

break;

+ case IrOpcode::kSpeculativeNumberBitwiseOr:

+ case IrOpcode::kSpeculativeNumberBitwiseXor:

+ case IrOpcode::kSpeculativeNumberBitwiseAnd:

+ CheckUpperIs(node, Type::Signed32());

+ break;

case IrOpcode::kNumberShiftLeft:

case IrOpcode::kNumberShiftRight:

// (Signed32, Unsigned32) -> Signed32

« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »