Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/compiler/verifier.cc

Issue 2201073002: [turbofan] Adds speculative operator for bitwise and, or and xor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Handles kSigned32 feedback. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 CheckUpperIs(node, Type::Number()); 705 CheckUpperIs(node, Type::Number());
706 break; 706 break;
707 case IrOpcode::kNumberBitwiseOr: 707 case IrOpcode::kNumberBitwiseOr:
708 case IrOpcode::kNumberBitwiseXor: 708 case IrOpcode::kNumberBitwiseXor:
709 case IrOpcode::kNumberBitwiseAnd: 709 case IrOpcode::kNumberBitwiseAnd:
710 // (Signed32, Signed32) -> Signed32 710 // (Signed32, Signed32) -> Signed32
711 CheckValueInputIs(node, 0, Type::Signed32()); 711 CheckValueInputIs(node, 0, Type::Signed32());
712 CheckValueInputIs(node, 1, Type::Signed32()); 712 CheckValueInputIs(node, 1, Type::Signed32());
713 CheckUpperIs(node, Type::Signed32()); 713 CheckUpperIs(node, Type::Signed32());
714 break; 714 break;
715 case IrOpcode::kSpeculativeNumberBitwiseOr:
716 case IrOpcode::kSpeculativeNumberBitwiseXor:
717 case IrOpcode::kSpeculativeNumberBitwiseAnd:
718 CheckUpperIs(node, Type::Signed32());
719 break;
715 case IrOpcode::kNumberShiftLeft: 720 case IrOpcode::kNumberShiftLeft:
716 case IrOpcode::kNumberShiftRight: 721 case IrOpcode::kNumberShiftRight:
717 // (Signed32, Unsigned32) -> Signed32 722 // (Signed32, Unsigned32) -> Signed32
718 CheckValueInputIs(node, 0, Type::Signed32()); 723 CheckValueInputIs(node, 0, Type::Signed32());
719 CheckValueInputIs(node, 1, Type::Unsigned32()); 724 CheckValueInputIs(node, 1, Type::Unsigned32());
720 CheckUpperIs(node, Type::Signed32()); 725 CheckUpperIs(node, Type::Signed32());
721 break; 726 break;
722 case IrOpcode::kSpeculativeNumberShiftLeft: 727 case IrOpcode::kSpeculativeNumberShiftLeft:
723 case IrOpcode::kSpeculativeNumberShiftRight: 728 case IrOpcode::kSpeculativeNumberShiftRight:
724 CheckUpperIs(node, Type::Signed32()); 729 CheckUpperIs(node, Type::Signed32());
(...skipping 833 matching lines...) Expand 10 before | Expand all | Expand 10 after
1558 replacement->op()->EffectOutputCount() > 0); 1563 replacement->op()->EffectOutputCount() > 0);
1559 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1564 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1560 replacement->opcode() == IrOpcode::kFrameState); 1565 replacement->opcode() == IrOpcode::kFrameState);
1561 } 1566 }
1562 1567
1563 #endif // DEBUG 1568 #endif // DEBUG
1564 1569
1565 } // namespace compiler 1570 } // namespace compiler
1566 } // namespace internal 1571 } // namespace internal
1567 } // namespace v8 1572 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698