Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2201073002: [turbofan] Adds speculative operator for bitwise and, or and xor. (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Adds speculative operator for bitwise and, or and xor. BUG= Committed: https://crrev.com/524abd76b7c1b5f10e4c8e56af6bca0cb52637f7 Cr-Commit-Position: refs/heads/master@{#38246}

Patch Set 1 #

Patch Set 2 : Handles kSigned32 feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -91 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/representation-change.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 chunks +25 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +16 lines, -10 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +19 lines, -25 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +12 lines, -49 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
epertoso
4 years, 4 months ago (2016-08-02 12:42:03 UTC) #6
Benedikt Meurer
Nice, thanks. LGTM.
4 years, 4 months ago (2016-08-02 12:54:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201073002/40001
4 years, 4 months ago (2016-08-02 13:39:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-02 13:41:57 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/524abd76b7c1b5f10e4c8e56af6bca0cb52637f7 Cr-Commit-Position: refs/heads/master@{#38246}
4 years, 4 months ago (2016-08-02 13:44:11 UTC) #18
Benedikt Meurer
4 years, 4 months ago (2016-08-02 16:53:19 UTC) #19
Message was sent while issue was closed.
Wow, got some nice Sunspider improvements!

Powered by Google App Engine
This is Rietveld 408576698