Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 2200943002: SoM: Alerts error handling. (Closed)

Created:
4 years, 4 months ago by zhangtiff
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added some tests for error handling. #

Total comments: 1

Patch Set 3 : Made some columns shorter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -9 lines) Patch
M go/src/infra/appengine/sheriff-o-matic/elements/som-app.html View 1 2 8 chunks +27 lines, -9 lines 0 comments Download
M go/src/infra/appengine/sheriff-o-matic/test/som-app-test.html View 1 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
zhangtiff
PTAL.
4 years, 4 months ago (2016-08-02 00:32:32 UTC) #2
seanmccullough1
test? https://codereview.chromium.org/2200943002/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right): https://codereview.chromium.org/2200943002/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html#newcode61 go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:61: color: #ff0000; Is #f00 equivalent?
4 years, 4 months ago (2016-08-02 00:44:30 UTC) #4
zhangtiff
On 2016/08/02 at 00:44:30, seanmccullough wrote: > test? > > https://codereview.chromium.org/2200943002/diff/1/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html > File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right): ...
4 years, 4 months ago (2016-08-03 22:23:23 UTC) #5
seanmccullough1
lgtm nit: 80col https://codereview.chromium.org/2200943002/diff/20001/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right): https://codereview.chromium.org/2200943002/diff/20001/go/src/infra/appengine/sheriff-o-matic/elements/som-app.html#newcode509 go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:509: this._fetchAlertsError = 'Server responded with 404: ...
4 years, 4 months ago (2016-08-04 16:11:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200943002/40001
4 years, 4 months ago (2016-08-04 17:12:35 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 17:28:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/3b2d7edcd7682aca8fe42c4b704e5...

Powered by Google App Engine
This is Rietveld 408576698