SoM: Alerts error handling.

SoM: Alerts error handling.

BUG=621156
Committed: https://chromium.googlesource.com/infra/infra/+/3b2d7edcd7682aca8fe42c4b704e5463dcaad485

[zhangtiff, 2016-08-02 00:32:32]

zhangtiff@chromium.org changed reviewers:
+ martiniss@chromium.org, seanmccullough@chromium.org

[zhangtiff, 2016-08-02 00:32:32]

PTAL.

[seanmccullough1, 2016-08-02 00:44:30]

seanmccullough@google.com changed reviewers:
+ seanmccullough@google.com

[seanmccullough1, 2016-08-02 00:44:30]

test?

https://codereview.chromium.org/2200943002/diff/1/go/src/infra/appengine/sher...
File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right):

https://codereview.chromium.org/2200943002/diff/1/go/src/infra/appengine/sher...
go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:61: color: #ff0000;
Is #f00 equivalent?

[zhangtiff, 2016-08-03 22:23:23]

On 2016/08/02 at 00:44:30, seanmccullough wrote:
> test?
> 
>
https://codereview.chromium.org/2200943002/diff/1/go/src/infra/appengine/sher...
> File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right):
> 
>
https://codereview.chromium.org/2200943002/diff/1/go/src/infra/appengine/sher...
> go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:61: color:
#ff0000;
> Is #f00 equivalent?

Changed the hex code and added a test for this. :)

[seanmccullough1, 2016-08-04 16:11:50]

lgtm

nit: 80col

https://codereview.chromium.org/2200943002/diff/20001/go/src/infra/appengine/...
File go/src/infra/appengine/sheriff-o-matic/elements/som-app.html (right):

https://codereview.chromium.org/2200943002/diff/20001/go/src/infra/appengine/...
go/src/infra/appengine/sheriff-o-matic/elements/som-app.html:509:
this._fetchAlertsError = 'Server responded with 404: ' + group + ' not found. ';
80 col here and below (silly requirement, I know)

[zhangtiff, 2016-08-04 17:12:32]

The CQ bit was checked by zhangtiff@chromium.org

[zhangtiff, 2016-08-04 17:12:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
seanmccullough@google.com
Link to the patchset: https://codereview.chromium.org/2200943002/#ps40001
(title: "Made some columns shorter.")

[commit-bot: I haz the power, 2016-08-04 17:12:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 17:28:06]

Description was changed from

==========
SoM: Alerts error handling.

BUG=621156
==========

to

==========
SoM: Alerts error handling.

BUG=621156

Committed:
https://chromium.googlesource.com/infra/infra/+/3b2d7edcd7682aca8fe42c4b704e5...
==========

[commit-bot: I haz the power, 2016-08-04 17:28:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/3b2d7edcd7682aca8fe42c4b704e5...