Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: go/src/infra/appengine/sheriff-o-matic/test/som-app-test.html

Issue 2200943002: SoM: Alerts error handling. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Made some columns shorter. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « go/src/infra/appengine/sheriff-o-matic/elements/som-app.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <meta charset="utf-8"> 2 <meta charset="utf-8">
3 <script src="/bower_components/webcomponentsjs/webcomponents.min.js"></script> 3 <script src="/bower_components/webcomponentsjs/webcomponents.min.js"></script>
4 <script src="/bower_components/web-component-tester/browser.js"></script> 4 <script src="/bower_components/web-component-tester/browser.js"></script>
5 <link rel="import" href="/bower_components/iron-test-helpers/iron-test-helpers.h tml"> 5 <link rel="import" href="/bower_components/iron-test-helpers/iron-test-helpers.h tml">
6 <link rel="import" href="/elements/som-app.html"> 6 <link rel="import" href="/elements/som-app.html">
7 <test-fixture id="basic"> 7 <test-fixture id="basic">
8 <template> 8 <template>
9 <som-app></som-app> 9 <som-app></som-app>
10 </template> 10 </template>
11 </test-fixture> 11 </test-fixture>
12 <script> 12 <script>
13 (function() { 13 (function() {
14 'use strict'; 14 'use strict';
15 var element; 15 var element;
16 var server; 16 var server;
17 var responseHeaders = { 17 var responseHeaders = {
18 json: {'Content-Type': 'application/json'}, 18 json: {'Content-Type': 'application/json'},
19 text: {'Content-Type': 'text/html'},
19 }; 20 };
20 21
21 setup(function() { 22 setup(function() {
22 element = fixture('basic'); 23 element = fixture('basic');
23 server = sinon.fakeServer.create(); 24 server = sinon.fakeServer.create();
24 server.respondWith( 25 server.respondWith(
25 'GET', 26 'GET',
26 '/api/v1/trees', [ 27 '/api/v1/trees', [
27 200, 28 200,
28 responseHeaders.json, 29 responseHeaders.json,
(...skipping 19 matching lines...) Expand all
48 test('renders bare minimum', function() { 49 test('renders bare minimum', function() {
49 element._alertsData = { 50 element._alertsData = {
50 test: [] 51 test: []
51 }; 52 };
52 element._alertsTimes = { 53 element._alertsTimes = {
53 test: new Date() 54 test: new Date()
54 }; 55 };
55 assert.equal( 56 assert.equal(
56 element.$$('.last-updated').textContent.trim(), 57 element.$$('.last-updated').textContent.trim(),
57 'Last updated: Unknown'); 58 'Last updated: Unknown');
59
60 expect(element.$.fetchAlertsError).be.hidden;
61 });
62
63 test('tree not found', function(done) {
64 let tree = 'notfound';
65 let groups = [tree];
66
67 element._alertsGroupsChanged(groups);
68
69 server.respondWith(
70 'GET',
71 '/api/v1/alerts/' + tree, [
72 404,
73 responseHeaders.text,
74 'Tree not found'
75 ]
76 );
77 server.respond();
78
79 flush(function() {
80 assert.notEqual(element._fetchAlertsError, '');
81 expect(element.$.fetchAlertsError).be.visible;
82 done();
83 });
58 }); 84 });
59 }); 85 });
60 86
61 suite('severity', function() { 87 suite('severity', function() {
62 test('renders severity groups', function(done) { 88 test('renders severity groups', function(done) {
63 element.set(['_alertsData', 'test'], [{ 89 element.set(['_alertsData', 'test'], [{
64 "key": "something", 90 "key": "something",
65 "severity": 2, 91 "severity": 2,
66 }]); 92 }]);
67 element._alertsTimes = { 93 element._alertsTimes = {
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 clock.tick(60 * 1000); 378 clock.tick(60 * 1000);
353 flush(function() { 379 flush(function() {
354 sinon.assert.calledOnce(refreshStub); 380 sinon.assert.calledOnce(refreshStub);
355 done(); 381 done();
356 }); 382 });
357 }); 383 });
358 384
359 }); 385 });
360 })(); 386 })();
361 </script> 387 </script>
OLDNEW
« no previous file with comments | « go/src/infra/appengine/sheriff-o-matic/elements/som-app.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698