content/shell/browser/shell_browser_main_parts.h - Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_browser_main_parts.h

Issue 2200693002: Refactor CrashDump*Manager to use a shared CrashDumpObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clang compile errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_browser_main_parts.h ('k') | content/shell/browser/shell_browser_main_parts.cc » ('j') | content/shell/browser/shell_content_browser_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_browser_main_parts.h

diff --git a/content/shell/browser/shell_browser_main_parts.h b/content/shell/browser/shell_browser_main_parts.h

index a11e961d7ff03f449c97a2d3e193056c81a63472..d641b8c8e54ad96abe9ea905986127fa9f5a78c4 100644

--- a/content/shell/browser/shell_browser_main_parts.h

+++ b/content/shell/browser/shell_browser_main_parts.h

@@ -13,12 +13,6 @@

#include "content/public/common/main_function_params.h"

#include "content/shell/browser/shell_browser_context.h"

-#if defined(OS_ANDROID)

-namespace breakpad {

-class CrashDumpManager;

-#endif

namespace base {

class Thread;

}

@@ -73,9 +67,6 @@ class ShellBrowserMainParts : public BrowserMainParts {

}

private:

-#if defined(OS_ANDROID)

- std::unique_ptr<breakpad::CrashDumpManager> crash_dump_manager_;

-#endif

std::unique_ptr<net::NetLog> net_log_;

std::unique_ptr<ShellBrowserContext> browser_context_;

std::unique_ptr<ShellBrowserContext> off_the_record_browser_context_;