Apply styles to mathML elements having class attribute.

Apply styles to mathML elements having class attribute.

BUG=580085
Committed: https://crrev.com/b51d74cb0739ddb0e3a608991dd2dba6856dd613
Cr-Commit-Position: refs/heads/master@{#410307}

[ramya.v, 2016-08-02 06:02:19]

ramya.v@samsung.com changed reviewers:
+ dstockwell@chromium.org, timloh@chromium.org

[ramya.v, 2016-08-02 06:02:20]

PTAL!


Thanks

[Timothy Loh, 2016-08-02 06:15:39]

On 2016/08/02 06:02:20, ramya.v wrote:
> PTAL!
> 
> 
> Thanks

Are there specs which define which sorts of elements can or can't be styled?

[ramya.v, 2016-08-02 08:43:00]

On 2016/08/02 06:15:39, Timothy Loh wrote:
> On 2016/08/02 06:02:20, ramya.v wrote:
> > PTAL!
> > 
> > 
> > Thanks
> 
> Are there specs which define which sorts of elements can or can't be styled?

I could not find any spec related to this. 
But in revision history I could find the below patches.

1) https://codereview.chromium.org/18139007 (Removing bit state from style
resolver)
2) http://trac.webkit.org/changeset/114806/trunk/Source/WebCore/dom/Node.h 
(Removing NodeTypeTag enum and creating separate bit for styled element)
(Before this they were considering MathML family also along with HTML and SVG
elements as styled elements)

[PhistucK, 2016-08-02 15:40:47]

phistuck@gmail.com changed reviewers:
+ phistuck@gmail.com

[PhistucK, 2016-08-02 15:40:47]

I know it is a copied comment, but while you are there. ;)

https://codereview.chromium.org/2200653002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/2200653002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.cpp:1034: // class names (ex. class="foo
bar") and other non-basic styling features. They and also control
s/They and also/Then also/

[ramya.v, 2016-08-03 04:03:49]

https://codereview.chromium.org/2200653002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/2200653002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.cpp:1034: // class names (ex. class="foo
bar") and other non-basic styling features. They and also control
On 2016/08/02 15:40:47, PhistucK wrote:
> s/They and also/Then also/

Done.

[Timothy Loh, 2016-08-05 04:51:40]

On 2016/08/02 08:43:00, ramya.v wrote:
> On 2016/08/02 06:15:39, Timothy Loh wrote:
> > On 2016/08/02 06:02:20, ramya.v wrote:
> > > PTAL!
> > > 
> > > 
> > > Thanks
> > 
> > Are there specs which define which sorts of elements can or can't be styled?
> 
> I could not find any spec related to this. 
> But in revision history I could find the below patches.
> 
> 1) https://codereview.chromium.org/18139007 (Removing bit state from style
> resolver)
> 2) http://trac.webkit.org/changeset/114806/trunk/Source/WebCore/dom/Node.h 
> (Removing NodeTypeTag enum and creating separate bit for styled element)
> (Before this they were considering MathML family also along with HTML and SVG
> elements as styled elements)

Thanks for the links, lgtm

[ramya.v, 2016-08-05 04:52:49]

The CQ bit was checked by ramya.v@samsung.com

[commit-bot: I haz the power, 2016-08-05 04:53:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 06:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 06:22:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramya.v, 2016-08-05 07:16:19]

The CQ bit was checked by ramya.v@samsung.com

[commit-bot: I haz the power, 2016-08-05 07:16:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 08:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 08:30:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramya.v, 2016-08-08 04:22:06]

The CQ bit was checked by ramya.v@samsung.com

[commit-bot: I haz the power, 2016-08-08 04:22:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 06:07:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-08 06:08:54]

Description was changed from

==========
Apply styles to mathML elements having class attribute.

BUG=580085
==========

to

==========
Apply styles to mathML elements having class attribute.

BUG=580085

Committed: https://crrev.com/b51d74cb0739ddb0e3a608991dd2dba6856dd613
Cr-Commit-Position: refs/heads/master@{#410307}
==========

[commit-bot: I haz the power, 2016-08-08 06:08:55]

Patchset 3 (id:??) landed as
https://crrev.com/b51d74cb0739ddb0e3a608991dd2dba6856dd613
Cr-Commit-Position: refs/heads/master@{#410307}