Remove StyleResolverState::styledElement() since we can just check isHTMLElement() or isSVGElement()

Remove StyleResolverState::styledElement() since we can just check isHTMLElement() or isSVGElement()

StyledElement just means "HTML or SVG element" so we can just check that in the getter
and use element() in the StyleResolver. This removes one more bit of state from the
style resolver and simplifies the code.

R=eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154096

[eseidel, 2013-07-12 06:31:31]

lgtm

https://codereview.chromium.org/18139007/diff/1/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/18139007/diff/1/Source/core/dom/Node.h#newcod...
Source/core/dom/Node.h:261: bool isStyledElement() const { return
isHTMLElement() || isSVGElement(); }
How do you know this to be true?  could you add a comment explaining why this is
the case?

[esprehn, 2013-07-12 06:37:03]

On 2013/07/12 06:31:31, eseidel wrote:
> lgtm
> 
> https://codereview.chromium.org/18139007/diff/1/Source/core/dom/Node.h
> File Source/core/dom/Node.h (right):
> 
>
https://codereview.chromium.org/18139007/diff/1/Source/core/dom/Node.h#newcod...
> Source/core/dom/Node.h:261: bool isStyledElement() const { return
> isHTMLElement() || isSVGElement(); }
> How do you know this to be true?  could you add a comment explaining why this
is
> the case?

This is true because that's where the bit fields were set. See the flags I
removed:

 CreateStyledElement = CreateElement | IsStyledElementFlag,
 CreateHTMLElement = CreateStyledElement | IsHTMLFlag,
 CreateSVGElement = CreateStyledElement | IsSVGFlag,

So only things that are isHTML or isSVG ever had the isStyled bit set. I don't
know what the comment would say, "Before this used to be a bit field but we only
set it on SVG and HTML" ? :P

[eseidel, 2013-07-12 06:50:27]

lgtm

OK.

[commit-bot: I haz the power, 2013-07-12 06:50:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/18139007/5001

[commit-bot: I haz the power, 2013-07-12 07:26:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/18139007/10002

[esprehn, 2013-07-12 07:40:11]

Committed patchset #3 manually as r154096 (presubmit successful).