Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Issue 2200483002: Geolocation cleanup: run clang-format (Closed)

Created:
4 years, 4 months ago by mcasas
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Geolocation cleanup: run clang-format After moving geolocation to device, the presubmit kept saying that I had to run git cl format, so here we go. No new code, just ran: clang-format -i -style=Chromium device/geolocation/*.h clang-format -i -style=Chromium device/geolocation/*.cc Committed: https://crrev.com/f50e159e802056823118d3f3deb4b23bd9335aba Cr-Commit-Position: refs/heads/master@{#408821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -427 lines) Patch
M device/geolocation/access_token_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/geolocation/empty_wifi_data_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/geolocation/empty_wifi_data_provider.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M device/geolocation/fake_access_token_store.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M device/geolocation/geolocation_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M device/geolocation/geolocation_provider_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/geolocation/geolocation_provider_impl.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M device/geolocation/geolocation_provider_impl_unittest.cc View 8 chunks +13 lines, -20 lines 0 comments Download
M device/geolocation/geolocation_service_context.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M device/geolocation/geolocation_service_impl.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M device/geolocation/geoposition.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M device/geolocation/location_api_adapter_android.h View 1 chunk +8 lines, -4 lines 0 comments Download
M device/geolocation/location_api_adapter_android.cc View 6 chunks +21 lines, -16 lines 0 comments Download
M device/geolocation/location_arbitrator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/geolocation/location_arbitrator_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/geolocation/location_arbitrator_impl_unittest.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M device/geolocation/location_provider_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/geolocation/location_provider_base.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M device/geolocation/mock_location_arbitrator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M device/geolocation/mock_location_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/geolocation/network_location_provider.h View 2 chunks +2 lines, -4 lines 0 comments Download
M device/geolocation/network_location_provider.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M device/geolocation/network_location_provider_unittest.cc View 7 chunks +29 lines, -26 lines 0 comments Download
M device/geolocation/network_location_request.cc View 9 chunks +31 lines, -36 lines 0 comments Download
M device/geolocation/wifi_data.h View 1 chunk +1 line, -1 line 0 comments Download
M device/geolocation/wifi_data.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M device/geolocation/wifi_data_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/geolocation/wifi_data_provider_chromeos.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M device/geolocation/wifi_data_provider_chromeos_unittest.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M device/geolocation/wifi_data_provider_common.cc View 1 chunk +6 lines, -14 lines 0 comments Download
M device/geolocation/wifi_data_provider_common_unittest.cc View 4 chunks +12 lines, -24 lines 0 comments Download
M device/geolocation/wifi_data_provider_common_win.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M device/geolocation/wifi_data_provider_linux.cc View 10 chunks +20 lines, -31 lines 0 comments Download
M device/geolocation/wifi_data_provider_linux_unittest.cc View 4 chunks +17 lines, -26 lines 0 comments Download
M device/geolocation/wifi_data_provider_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M device/geolocation/wifi_data_provider_mac.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M device/geolocation/wifi_data_provider_win.cc View 20 chunks +60 lines, -106 lines 0 comments Download
M device/geolocation/wifi_polling_policy.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mcasas
reillyg@ PTAL/RS
4 years, 4 months ago (2016-07-29 22:22:23 UTC) #3
Reilly Grant (use Gerrit)
lgtm
4 years, 4 months ago (2016-07-29 22:49:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200483002/1
4 years, 4 months ago (2016-07-29 22:54:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/253541) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 4 months ago (2016-07-29 23:04:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200483002/1
4 years, 4 months ago (2016-07-30 00:07:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 00:44:53 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 00:46:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f50e159e802056823118d3f3deb4b23bd9335aba
Cr-Commit-Position: refs/heads/master@{#408821}

Powered by Google App Engine
This is Rietveld 408576698