[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
R=asvitkine@chromium.org,bradnelson@chromium.org

Committed: https://crrev.com/fd14ddaa3db539a70536d45b98b3b9e599ecc2a3
Cr-Commit-Position: refs/heads/master@{#411307}

[John, 2016-08-02 23:18:56]

Description was changed from

==========
[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG=
==========

to

==========
[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
==========

[John, 2016-08-02 23:19:15]

jpp@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bradnelson, 2016-08-02 23:46:06]

https://codereview.chromium.org/2200403002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2200403002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5838: +      <message
name="IDS_FLAGS_ENABLE_ASM_WASM_NAME" desc="Title for the flag to enable Asm.js
to WebAssembly.">
How about:
Experimental Validate Asm.js and convert to WebAssembly internally when valid.

https://codereview.chromium.org/2200403002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5842: +        Enable web pages to use
experimental Asm.js to WebAssembly.
How about:
Validate Asm.js when "use asm" is present and then convert to WebAssembly
internally.

https://codereview.chromium.org/2200403002/diff/1/content/renderer/render_pro...
File content/renderer/render_process_impl.cc (right):

https://codereview.chromium.org/2200403002/diff/1/content/renderer/render_pro...
content/renderer/render_process_impl.cc:89:
SetV8FlagIfHasSwitch(switches::kEnableAsmWasm, "--expose-wasm");
The flag is actually --validate-asm

[John, 2016-08-03 14:12:15]

https://codereview.chromium.org/2200403002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2200403002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5838: +      <message
name="IDS_FLAGS_ENABLE_ASM_WASM_NAME" desc="Title for the flag to enable Asm.js
to WebAssembly.">
On 2016/08/02 23:46:06, bradnelson wrote:
> How about:
> Experimental Validate Asm.js and convert to WebAssembly internally when valid.

Done.

https://codereview.chromium.org/2200403002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5842: +        Enable web pages to use
experimental Asm.js to WebAssembly.
On 2016/08/02 23:46:06, bradnelson wrote:
> How about:
> Validate Asm.js when "use asm" is present and then convert to WebAssembly
> internally.

Done.

https://codereview.chromium.org/2200403002/diff/1/content/renderer/render_pro...
File content/renderer/render_process_impl.cc (right):

https://codereview.chromium.org/2200403002/diff/1/content/renderer/render_pro...
content/renderer/render_process_impl.cc:89:
SetV8FlagIfHasSwitch(switches::kEnableAsmWasm, "--expose-wasm");
On 2016/08/02 23:46:06, bradnelson wrote:
> The flag is actually --validate-asm

unrelated to this CL, but the asm-wasm tests don't use --validate-asm, they use
--expose-wasm. Is this expected?

[bradn, 2016-08-03 23:03:12]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-08-03 23:03:13]

That will be changing once I've landed the thunk change to support modules with
less than 3 args.

[bradnelson, 2016-08-03 23:04:18]

lgtm, but you'll need other OWNERS added to the review

[bradnelson, 2016-08-04 01:21:32]

Description was changed from

==========
[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
==========

to

==========
[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
R=asvitkine@chromium.org,bradnelson@chromium.org
==========

[bradnelson, 2016-08-04 01:21:32]

bradnelson@chromium.org changed reviewers:
+ asvitkine@chromium.org

[bradnelson, 2016-08-04 01:21:52]

+ asvitkine for OWNERS

[Alexei Svitkine (slow), 2016-08-04 15:58:52]

lgtm

[bradn, 2016-08-04 18:28:10]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-08-04 18:29:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 18:39:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 18:39:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bradn, 2016-08-04 20:47:14]

Looks like the test in chrome/browser/about_flags_unittest.cc needs to be
updated.
Also we'll need an OWNER from content, maybe jam?
Maybe sort trybots first.

[John, 2016-08-10 14:04:24]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 14:04:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:50:42]

Dry run: This issue passed the CQ dry run.

[John, 2016-08-10 15:56:38]

jpp@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2016-08-10 17:32:50]

lgtm with comment

https://codereview.chromium.org/2200403002/diff/40001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2200403002/diff/40001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:1638: switches::kEnableAsmWasm,
since this is a command line flag that content knows about, move this line to
RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer

(that way the flag is propagated for all content-based browsers, not just
chrome)

[John, 2016-08-11 11:33:00]

https://codereview.chromium.org/2200403002/diff/40001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2200403002/diff/40001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:1638: switches::kEnableAsmWasm,
On 2016/08/10 17:32:50, jam wrote:
> since this is a command line flag that content knows about, move this line to
> RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer
> 
> (that way the flag is propagated for all content-based browsers, not just
> chrome)

Done.
As per offline talk, kEnableWasm was also moved to that method.

[John, 2016-08-11 11:33:30]

The CQ bit was checked by jpp@chromium.org

[John, 2016-08-11 11:33:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org, asvitkine@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2200403002/#ps60001
(title: "addresses comments")

[commit-bot: I haz the power, 2016-08-11 11:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 12:23:53]

Description was changed from

==========
[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
R=asvitkine@chromium.org,bradnelson@chromium.org
==========

to

==========
[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
R=asvitkine@chromium.org,bradnelson@chromium.org
==========

[commit-bot: I haz the power, 2016-08-11 12:23:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-11 12:25:52]

Description was changed from

==========
[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
R=asvitkine@chromium.org,bradnelson@chromium.org
==========

to

==========
[asm.js] [wasm] Adds a UI flag for enabling the Wasm backend for Asm.js

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
R=asvitkine@chromium.org,bradnelson@chromium.org

Committed: https://crrev.com/fd14ddaa3db539a70536d45b98b3b9e599ecc2a3
Cr-Commit-Position: refs/heads/master@{#411307}
==========

[commit-bot: I haz the power, 2016-08-11 12:25:53]

Patchset 4 (id:??) landed as
https://crrev.com/fd14ddaa3db539a70536d45b98b3b9e599ecc2a3
Cr-Commit-Position: refs/heads/master@{#411307}

[xidachen, 2016-08-11 13:32:57]

On 2016/08/11 12:25:53, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/fd14ddaa3db539a70536d45b98b3b9e599ecc2a3
> Cr-Commit-Position: refs/heads/master@{#411307}

Hi, sheriff here.

I have created a revert of this CL here:
https://codereview.chromium.org/2236963002/

Because I suspect this CL causes compilation failure:
https://build.chromium.org/p/chromium/builders/Win/builds/46119
Error message:
src\components\translate\content\browser\content_translate_driver.h(13): fatal
error C1083: Cannot open include file:
'components/translate/content/common/translate.mojom.h': No such file or
directory

[xidachen, 2016-08-11 13:37:32]

On 2016/08/11 13:32:57, xidachen wrote:
> On 2016/08/11 12:25:53, commit-bot: I haz the power wrote:
> > Patchset 4 (id:??) landed as
> > https://crrev.com/fd14ddaa3db539a70536d45b98b3b9e599ecc2a3
> > Cr-Commit-Position: refs/heads/master@{#411307}
> 
> Hi, sheriff here.
> 
> I have created a revert of this CL here:
> https://codereview.chromium.org/2236963002/
> 
> Because I suspect this CL causes compilation failure:
> https://build.chromium.org/p/chromium/builders/Win/builds/46119
> Error message:
> src\components\translate\content\browser\content_translate_driver.h(13): fatal
> error C1083: Cannot open include file:
> 'components/translate/content/common/translate.mojom.h': No such file or
> directory

sorry, my bad, not reverting this.