Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: services/ui/common/gpu_service.h

Issue 2200353002: Revert of services/ui: Have an explicit lifetime/ownership of ui::GpuService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | services/ui/common/gpu_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_UI_COMMON_GPU_SERVICE_H_ 5 #ifndef SERVICES_UI_COMMON_GPU_SERVICE_H_
6 #define SERVICES_UI_COMMON_GPU_SERVICE_H_ 6 #define SERVICES_UI_COMMON_GPU_SERVICE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "base/single_thread_task_runner.h" 13 #include "base/single_thread_task_runner.h"
14 #include "base/synchronization/lock.h" 14 #include "base/synchronization/lock.h"
15 #include "base/synchronization/waitable_event.h" 15 #include "base/synchronization/waitable_event.h"
16 #include "base/threading/thread.h" 16 #include "base/threading/thread.h"
17 #include "gpu/ipc/client/gpu_channel_host.h" 17 #include "gpu/ipc/client/gpu_channel_host.h"
18 #include "services/ui/common/mojo_gpu_memory_buffer_manager.h" 18 #include "services/ui/common/mojo_gpu_memory_buffer_manager.h"
19 #include "services/ui/common/mus_common_export.h" 19 #include "services/ui/common/mus_common_export.h"
20 #include "services/ui/public/interfaces/gpu_service.mojom.h" 20 #include "services/ui/public/interfaces/gpu_service.mojom.h"
21 21
22 namespace shell { 22 namespace shell {
23 class Connector; 23 class Connector;
24 } 24 }
25 25
26 namespace ui { 26 namespace ui {
27 27
28 class MUS_COMMON_EXPORT GpuService : public gpu::GpuChannelHostFactory { 28 class MUS_COMMON_EXPORT GpuService : public gpu::GpuChannelHostFactory {
29 public: 29 public:
30 ~GpuService() override;
31
32 void EstablishGpuChannel(const base::Closure& callback); 30 void EstablishGpuChannel(const base::Closure& callback);
33 scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync(); 31 scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync();
34 scoped_refptr<gpu::GpuChannelHost> GetGpuChannel(); 32 scoped_refptr<gpu::GpuChannelHost> GetGpuChannel();
35 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager() const { 33 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager() const {
36 return gpu_memory_buffer_manager_.get(); 34 return gpu_memory_buffer_manager_.get();
37 } 35 }
38 36
39 // The GpuService has to be initialized in the main thread before establishing 37 // The GpuService has to be initialized in the main thread before establishing
40 // the gpu channel. 38 // the gpu channel.
41 static std::unique_ptr<GpuService> Initialize(shell::Connector* connector); 39 static void Initialize(shell::Connector* connector);
40 // The GpuService has to be terminated in the main thread.
41 static void Terminate();
42 static GpuService* GetInstance(); 42 static GpuService* GetInstance();
43 43
44 private: 44 private:
45 friend struct base::DefaultSingletonTraits<GpuService>; 45 friend struct base::DefaultSingletonTraits<GpuService>;
46 46
47 explicit GpuService(shell::Connector* connector); 47 explicit GpuService(shell::Connector* connector);
48 ~GpuService() override;
48 49
49 scoped_refptr<gpu::GpuChannelHost> GetGpuChannelLocked(); 50 scoped_refptr<gpu::GpuChannelHost> GetGpuChannelLocked();
50 void EstablishGpuChannelOnMainThread(); 51 void EstablishGpuChannelOnMainThread();
51 void EstablishGpuChannelOnMainThreadSyncLocked(); 52 void EstablishGpuChannelOnMainThreadSyncLocked();
52 void EstablishGpuChannelOnMainThreadDone( 53 void EstablishGpuChannelOnMainThreadDone(
53 bool locked, 54 bool locked,
54 int client_id, 55 int client_id,
55 mojom::ChannelHandlePtr channel_handle, 56 mojom::ChannelHandlePtr channel_handle,
56 mojom::GpuInfoPtr gpu_info); 57 mojom::GpuInfoPtr gpu_info);
57 58
(...skipping 16 matching lines...) Expand all
74 scoped_refptr<gpu::GpuChannelHost> gpu_channel_; 75 scoped_refptr<gpu::GpuChannelHost> gpu_channel_;
75 std::vector<base::Closure> establish_callbacks_; 76 std::vector<base::Closure> establish_callbacks_;
76 base::ConditionVariable establishing_condition_; 77 base::ConditionVariable establishing_condition_;
77 78
78 DISALLOW_COPY_AND_ASSIGN(GpuService); 79 DISALLOW_COPY_AND_ASSIGN(GpuService);
79 }; 80 };
80 81
81 } // namespace ui 82 } // namespace ui
82 83
83 #endif // COMPONENTS_MUS_PUBLIC_CPP_LIB_GPU_SERVICE_CONNECTION_H_ 84 #endif // COMPONENTS_MUS_PUBLIC_CPP_LIB_GPU_SERVICE_CONNECTION_H_
OLDNEW
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | services/ui/common/gpu_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698