[serializer][heap] Record references in deserialized code objects.

[serializer][heap] Record references in deserialized code objects.

References in code objects to new-space embedded objects have to be
recorded in a remembered set so that they get updated by the garbage
collector.

TEST=cctest/test-serialize/CodeSerializerEmbeddedObject

R=ulan@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/7a1deffbd1b06c8edc0215f07dc4029e56cc8878
Cr-Commit-Position: refs/heads/master@{#38335}

[ahaas, 2016-08-03 12:18:33]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 12:18:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-08-03 12:29:52]

lgtm.

https://codereview.chromium.org/2200333004/diff/1/src/snapshot/deserializer.cc
File src/snapshot/deserializer.cc (right):

https://codereview.chromium.org/2200333004/diff/1/src/snapshot/deserializer.c...
src/snapshot/deserializer.cc:47: isolate_->heap()->RecordWriteIntoCode(code,
it.rinfo(),
This entire for loop is duplicate code from CopyCode. Could we have it only once
and call to it?

[commit-bot: I haz the power, 2016-08-03 12:43:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 12:43:12]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-08-04 08:36:34]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 08:36:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-08-04 08:54:11]

https://codereview.chromium.org/2200333004/diff/1/src/snapshot/deserializer.cc
File src/snapshot/deserializer.cc (right):

https://codereview.chromium.org/2200333004/diff/1/src/snapshot/deserializer.c...
src/snapshot/deserializer.cc:47: isolate_->heap()->RecordWriteIntoCode(code,
it.rinfo(),
On 2016/08/03 at 12:29:52, Yang wrote:
> This entire for loop is duplicate code from CopyCode. Could we have it only
once and call to it?

Done.

[Yang, 2016-08-04 08:56:39]

lgtm

[ulan, 2016-08-04 08:56:44]

lgtm, nice!

[commit-bot: I haz the power, 2016-08-04 09:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 09:06:26]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-08-04 09:34:22]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-08-04 09:34:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 09:36:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-04 09:40:05]

Description was changed from

==========
[serializer][heap] Record references in deserialized code objects.

References in code objects to new-space embedded objects have to be
recorded in a remembered set so that they get updated by the garbage
collector.

TEST=cctest/test-serialize/CodeSerializerEmbeddedObject

R=ulan@chromium.org, yangguo@chromium.org
==========

to

==========
[serializer][heap] Record references in deserialized code objects.

References in code objects to new-space embedded objects have to be
recorded in a remembered set so that they get updated by the garbage
collector.

TEST=cctest/test-serialize/CodeSerializerEmbeddedObject

R=ulan@chromium.org, yangguo@chromium.org

Committed: https://crrev.com/7a1deffbd1b06c8edc0215f07dc4029e56cc8878
Cr-Commit-Position: refs/heads/master@{#38335}
==========

[commit-bot: I haz the power, 2016-08-04 09:40:06]

Patchset 2 (id:??) landed as
https://crrev.com/7a1deffbd1b06c8edc0215f07dc4029e56cc8878
Cr-Commit-Position: refs/heads/master@{#38335}