[Cronet] Add BUILD.gn for legacy ios/CrNet project.

[Cronet] Add BUILD.gn for legacy ios/CrNet project.

BUG=527059
Committed: https://crrev.com/6c1a3dd6ee7b9f0ae2b2308e993b8fd94895b252
Cr-Commit-Position: refs/heads/master@{#415312}

[mef, 2016-08-02 21:32:40]

mef@chromium.org changed reviewers:
+ droger@chromium.org, sdefresne@chromium.org

[mef, 2016-08-02 21:32:41]

Hi, PTAL. 

I'm adding ios/crnet/BUILD.gn to use instead of GYP until we transition to
components/cronet/ios.

I'm not sure what to do with Resources/Localization. Is it still useful? 
I can't find its counterpart in Chrome proper.
If it is useful, than what's a proper way to include it into bundle?

Also, is it possible to make crnet_consumer target to depend/include
crnet_framework dynamic framework instead of crnet_sources set?

Thanks,
-m

[sdefresne, 2016-08-02 21:54:11]

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
File ios/crnet/BUILD.gn (right):

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode1
ios/crnet/BUILD.gn:1: # Copyright 2015 The Chromium Authors. All rights
reserved.
2015 → 2016

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode71
ios/crnet/BUILD.gn:71: ios_app_bundle("crnet_consumer") {
Move this target to src/ios/crnet/crnet_consumer/BUILD.gn.

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode75
ios/crnet/BUILD.gn:75: ":crnet_sources",
I think this dependency should be removed and instead this application needs to
link against the crnet_framework and bundle it in the application (otherwise it
is not really exercising the fact that crnet is available as a framework as it
directly link the crnet source).

I think you should be able to get this working by adding the following two
dependencies:

  ":crnet_framework+link",
  ":crnet_framework+bunde",

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode93
ios/crnet/BUILD.gn:93: test("crnet_test") {
Move this target to src/ios/crnet/test/BUILD.gn.

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode101
ios/crnet/BUILD.gn:101: ":crnet_sources",
ditto about dependency on ":crnet_sources"

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/crnet_consumer/cr...
File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:7: #import
"ios/crnet/CrNet.h"
If you follow my recommendation about using crnet_framework+{bind,bundle}, I
think you will have to revert those #import changes.

[mef, 2016-08-02 22:19:17]

Thanks for your comments! I'll split BUILD.gn files in next patch, but I'm
unable to run crnet_consumer with embedded framework on simulator (getting
cryptic error).

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
File ios/crnet/BUILD.gn (right):

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode1
ios/crnet/BUILD.gn:1: # Copyright 2015 The Chromium Authors. All rights
reserved.
On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> 2015 → 2016

Done.

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode75
ios/crnet/BUILD.gn:75: ":crnet_sources",
On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> I think this dependency should be removed and instead this application needs
to link against the crnet_framework and bundle it in the application (otherwise
it is not really exercising the fact that crnet is available as a framework as
it directly link the crnet source).
> 
> I think you should be able to get this working by adding the following two
dependencies:
> 
>   ":crnet_framework+link",
>   ":crnet_framework+bunde",

Done. The crnet_consumer app now has embedded framework, but starting on
simulator fails with cryptic error: LaunchServicesError error 0.

[mef, 2016-08-03 16:18:26]

On 2016/08/02 at 22:19:17, mef wrote:
> Thanks for your comments! I'll split BUILD.gn files in next patch, but I'm
unable to run crnet_consumer with embedded framework on simulator (getting
cryptic error).
> 
> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
> File ios/crnet/BUILD.gn (right):
> 
> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode1
> ios/crnet/BUILD.gn:1: # Copyright 2015 The Chromium Authors. All rights
reserved.
> On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > 2015 → 2016
> 
> Done.
> 
> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode75
> ios/crnet/BUILD.gn:75: ":crnet_sources",
> On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > I think this dependency should be removed and instead this application needs
to link against the crnet_framework and bundle it in the application (otherwise
it is not really exercising the fact that crnet is available as a framework as
it directly link the crnet source).
> > 
> > I think you should be able to get this working by adding the following two
dependencies:
> > 
> >   ":crnet_framework+link",
> >   ":crnet_framework+bunde",
> 
> Done. The crnet_consumer app now has embedded framework, but starting on
simulator fails with cryptic error: LaunchServicesError error 0.

I see this error in system log:

Aug  3 12:09:10 mef-macbookpro
com.apple.CoreSimulator.CoreSimulatorService[459]: Error
Domain=LaunchServicesError Code=0 "(null)"
UserInfo={Error=MissingBundleIdentifier, ErrorDescription=Bundle at path
/Users/mef/Library/Developer/CoreSimulator/Devices/ED2690CF-D77F-4AF2-8D98-A0675CAC56AC/data/Library/Caches/com.apple.mobile.installd.staging/temp.BkWTeP/extracted/crnet_consumer.app/Frameworks/CrNet.framework
did not have a CFBundleIdentifier in its Info.plist}

Any ideas?

[sdefresne, 2016-08-03 16:42:12]

On 2016/08/03 16:18:26, mef wrote:
> On 2016/08/02 at 22:19:17, mef wrote:
> > Thanks for your comments! I'll split BUILD.gn files in next patch, but I'm
> unable to run crnet_consumer with embedded framework on simulator (getting
> cryptic error).
> > 
> > https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
> > File ios/crnet/BUILD.gn (right):
> > 
> >
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode1
> > ios/crnet/BUILD.gn:1: # Copyright 2015 The Chromium Authors. All rights
> reserved.
> > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > 2015 → 2016
> > 
> > Done.
> > 
> >
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode75
> > ios/crnet/BUILD.gn:75: ":crnet_sources",
> > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > I think this dependency should be removed and instead this application
needs
> to link against the crnet_framework and bundle it in the application
(otherwise
> it is not really exercising the fact that crnet is available as a framework as
> it directly link the crnet source).
> > > 
> > > I think you should be able to get this working by adding the following two
> dependencies:
> > > 
> > >   ":crnet_framework+link",
> > >   ":crnet_framework+bunde",
> > 
> > Done. The crnet_consumer app now has embedded framework, but starting on
> simulator fails with cryptic error: LaunchServicesError error 0.
> 
> I see this error in system log:
> 
> Aug  3 12:09:10 mef-macbookpro
> com.apple.CoreSimulator.CoreSimulatorService[459]: Error
> Domain=LaunchServicesError Code=0 "(null)"
> UserInfo={Error=MissingBundleIdentifier, ErrorDescription=Bundle at path
>
/Users/mef/Library/Developer/CoreSimulator/Devices/ED2690CF-D77F-4AF2-8D98-A0675CAC56AC/data/Library/Caches/com.apple.mobile.installd.staging/temp.BkWTeP/extracted/crnet_consumer.app/Frameworks/CrNet.framework
> did not have a CFBundleIdentifier in its Info.plist}
> 
> Any ideas?

The error mentions that CrNet.framework/Info.plist does not define
CFBundleIdentifier.
Can you check the content of the file?

Which version of Xcode are you using?

[mef, 2016-08-03 16:51:36]

On 2016/08/03 at 16:42:12, sdefresne wrote:
> On 2016/08/03 16:18:26, mef wrote:
> > On 2016/08/02 at 22:19:17, mef wrote:
> > > Thanks for your comments! I'll split BUILD.gn files in next patch, but I'm
> > unable to run crnet_consumer with embedded framework on simulator (getting
> > cryptic error).
> > > 
> > > https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
> > > File ios/crnet/BUILD.gn (right):
> > > 
> > >
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode1
> > > ios/crnet/BUILD.gn:1: # Copyright 2015 The Chromium Authors. All rights
> > reserved.
> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > > 2015 → 2016
> > > 
> > > Done.
> > > 
> > >
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode75
> > > ios/crnet/BUILD.gn:75: ":crnet_sources",
> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > > I think this dependency should be removed and instead this application
needs
> > to link against the crnet_framework and bundle it in the application
(otherwise
> > it is not really exercising the fact that crnet is available as a framework
as
> > it directly link the crnet source).
> > > > 
> > > > I think you should be able to get this working by adding the following
two
> > dependencies:
> > > > 
> > > >   ":crnet_framework+link",
> > > >   ":crnet_framework+bunde",
> > > 
> > > Done. The crnet_consumer app now has embedded framework, but starting on
> > simulator fails with cryptic error: LaunchServicesError error 0.
> > 
> > I see this error in system log:
> > 
> > Aug  3 12:09:10 mef-macbookpro
> > com.apple.CoreSimulator.CoreSimulatorService[459]: Error
> > Domain=LaunchServicesError Code=0 "(null)"
> > UserInfo={Error=MissingBundleIdentifier, ErrorDescription=Bundle at path
> >
/Users/mef/Library/Developer/CoreSimulator/Devices/ED2690CF-D77F-4AF2-8D98-A0675CAC56AC/data/Library/Caches/com.apple.mobile.installd.staging/temp.BkWTeP/extracted/crnet_consumer.app/Frameworks/CrNet.framework
> > did not have a CFBundleIdentifier in its Info.plist}
> > 
> > Any ideas?
> 
> The error mentions that CrNet.framework/Info.plist does not define
CFBundleIdentifier.
> Can you check the content of the file?

Yep, I see CFBundleIdentifier set to "org.chromium.net.CrNet".
> 
> Which version of Xcode are you using?
7.3.1

[mef, 2016-08-03 17:54:10]

On 2016/08/03 at 16:51:36, mef wrote:
> On 2016/08/03 at 16:42:12, sdefresne wrote:
> > On 2016/08/03 16:18:26, mef wrote:
> > > On 2016/08/02 at 22:19:17, mef wrote:
> > > > Thanks for your comments! I'll split BUILD.gn files in next patch, but
I'm
> > > unable to run crnet_consumer with embedded framework on simulator (getting
> > > cryptic error).
> > > > 
> > > > https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
> > > > File ios/crnet/BUILD.gn (right):
> > > > 
> > > >
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode1
> > > > ios/crnet/BUILD.gn:1: # Copyright 2015 The Chromium Authors. All rights
> > > reserved.
> > > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > > > 2015 → 2016
> > > > 
> > > > Done.
> > > > 
> > > >
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode75
> > > > ios/crnet/BUILD.gn:75: ":crnet_sources",
> > > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > > > I think this dependency should be removed and instead this application
needs
> > > to link against the crnet_framework and bundle it in the application
(otherwise
> > > it is not really exercising the fact that crnet is available as a
framework as
> > > it directly link the crnet source).
> > > > > 
> > > > > I think you should be able to get this working by adding the following
two
> > > dependencies:
> > > > > 
> > > > >   ":crnet_framework+link",
> > > > >   ":crnet_framework+bunde",
> > > > 
> > > > Done. The crnet_consumer app now has embedded framework, but starting on
> > > simulator fails with cryptic error: LaunchServicesError error 0.
> > > 
> > > I see this error in system log:
> > > 
> > > Aug  3 12:09:10 mef-macbookpro
> > > com.apple.CoreSimulator.CoreSimulatorService[459]: Error
> > > Domain=LaunchServicesError Code=0 "(null)"
> > > UserInfo={Error=MissingBundleIdentifier, ErrorDescription=Bundle at path
> > >
/Users/mef/Library/Developer/CoreSimulator/Devices/ED2690CF-D77F-4AF2-8D98-A0675CAC56AC/data/Library/Caches/com.apple.mobile.installd.staging/temp.BkWTeP/extracted/crnet_consumer.app/Frameworks/CrNet.framework
> > > did not have a CFBundleIdentifier in its Info.plist}
> > > 
> > > Any ideas?
> > 
> > The error mentions that CrNet.framework/Info.plist does not define
CFBundleIdentifier.
> > Can you check the content of the file?
> 
> Yep, I see CFBundleIdentifier set to "org.chromium.net.CrNet".
> > 
> > Which version of Xcode are you using?
> 7.3.1

I've played a bit more, and I have the following observations.

The Framework/CrNet.framework embedded into crnet_consumer.app includes Headers,
ModuleMap and Resources.
If I remove those directories, then the previous error goes away, and I get the
following error:

mef-macbookpro:src mef$ out/Debug-iphonesimulator/iossim
out/Debug-iphonesimulator/crnet_consumer.app
2016-08-03 13:51:15.520 iossim[97170:1833379] [MT] DVTAssertions: Warning in
/Library/Caches/com.apple.xbs/Sources/DVTFrameworks/DVTFrameworks-10179/DVTFoundation/PlugInArchitecture/PlugInManager/DVTPlugInManager.m:260
Details:  Requested but did not find extension point with identifier
Xcode.DVTFoundation.DevicePlatformMapping
Object:   <DVTPlugInManager: 0x7fcb2e10e600>
Method:   -extensionPointWithIdentifier:
Thread:   <NSThread: 0x7fcb2bc0b750>{number = 1, name = main}
Please file a bug at http://bugreport.apple.com with this warning message and
any useful information you can provide.
dyld: Library not loaded: @rpath/CrNet.framework/CrNet
  Referenced from:
/Users/mef/Library/Developer/CoreSimulator/Devices/ED2690CF-D77F-4AF2-8D98-A0675CAC56AC/data/Containers/Bundle/Application/1F79DB9A-D107-42D5-882D-785E3DBB4B2D/crnet_consumer.app/crnet_consumer
  Reason: image not found
iossim: WARNING: Console message: Aug  3 13:51:18 mef-macbookpro
com.apple.CoreSimulator.SimDevice.ED2690CF-D77F-4AF2-8D98-A0675CAC56AC.launchd_sim[96792]
(UIKitApplication:chromium.crnet-consumer[0x5eaa][97174]): Service exited due to
signal: Trace/BPT trap: 5
iossim: ERROR: Simulated app crashed or exited with non-zero status

If I add CrNet.framework to test xcode project, then it is working fine.

Any ideas?

[mef, 2016-08-03 20:42:41]

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
File ios/crnet/BUILD.gn (right):

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode71
ios/crnet/BUILD.gn:71: ios_app_bundle("crnet_consumer") {
On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> Move this target to src/ios/crnet/crnet_consumer/BUILD.gn.

Done.

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode93
ios/crnet/BUILD.gn:93: test("crnet_test") {
On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> Move this target to src/ios/crnet/test/BUILD.gn.

Done.

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode101
ios/crnet/BUILD.gn:101: ":crnet_sources",
On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> ditto about dependency on ":crnet_sources"

Hrm, this target uses stuff that is not exported from crnet_framework.
I think it should keep using crnet_sources.

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/crnet_consumer/cr...
File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):

https://codereview.chromium.org/2200323003/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:7: #import
"ios/crnet/CrNet.h"
On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> If you follow my recommendation about using crnet_framework+{bind,bundle}, I
think you will have to revert those #import changes.

Using crnet_framework+bind results in gn error and using crnet_framework+link
still needs path to the header file. Any ideas?

[mef, 2016-08-05 14:34:34]

On 2016/08/03 20:42:41, mef wrote:
> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
> File ios/crnet/BUILD.gn (right):
> 
> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode71
> ios/crnet/BUILD.gn:71: ios_app_bundle("crnet_consumer") {
> On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > Move this target to src/ios/crnet/crnet_consumer/BUILD.gn.
> 
> Done.
> 
> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode93
> ios/crnet/BUILD.gn:93: test("crnet_test") {
> On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > Move this target to src/ios/crnet/test/BUILD.gn.
> 
> Done.
> 
>
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode101
> ios/crnet/BUILD.gn:101: ":crnet_sources",
> On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > ditto about dependency on ":crnet_sources"
> 
> Hrm, this target uses stuff that is not exported from crnet_framework.
> I think it should keep using crnet_sources.
> 
>
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/crnet_consumer/cr...
> File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):
> 
>
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/crnet_consumer/cr...
> ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:7: #import
> "ios/crnet/CrNet.h"
> On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > If you follow my recommendation about using crnet_framework+{bind,bundle}, I
> think you will have to revert those #import changes.
> 
> Using crnet_framework+bind results in gn error and using crnet_framework+link
> still needs path to the header file. Any ideas?

Sylvain: ping

[sdefresne, 2016-08-05 23:50:51]

On 2016/08/05 14:34:34, mef wrote:
> On 2016/08/03 20:42:41, mef wrote:
> > https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
> > File ios/crnet/BUILD.gn (right):
> > 
> >
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode71
> > ios/crnet/BUILD.gn:71: ios_app_bundle("crnet_consumer") {
> > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > Move this target to src/ios/crnet/crnet_consumer/BUILD.gn.
> > 
> > Done.
> > 
> >
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode93
> > ios/crnet/BUILD.gn:93: test("crnet_test") {
> > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > Move this target to src/ios/crnet/test/BUILD.gn.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn#newcode101
> > ios/crnet/BUILD.gn:101: ":crnet_sources",
> > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > ditto about dependency on ":crnet_sources"
> > 
> > Hrm, this target uses stuff that is not exported from crnet_framework.
> > I think it should keep using crnet_sources.
> > 
> >
>
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/crnet_consumer/cr...
> > File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):
> > 
> >
>
https://codereview.chromium.org/2200323003/diff/1/ios/crnet/crnet_consumer/cr...
> > ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:7: #import
> > "ios/crnet/CrNet.h"
> > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > If you follow my recommendation about using crnet_framework+{bind,bundle},
I
> > think you will have to revert those #import changes.
> > 
> > Using crnet_framework+bind results in gn error and using
crnet_framework+link
> > still needs path to the header file. Any ideas?
> 
> Sylvain: ping

Sorry, I did not have time to debug the failure. I'll try to take a look on
Monday.

[chromium-reviews, 2016-08-09 04:14:03]

I didn't get to this today either (I was trying to fix official builder for
Chrome on iOS, still failing for a different reason). I'll see if I can
have a look tomorrow.
-- Sylvain

On Fri, Aug 5, 2016 at 4:50 PM, <sdefresne@chromium.org> wrote:

> On 2016/08/05 14:34:34, mef wrote:
> > On 2016/08/03 20:42:41, mef wrote:
> > > https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
> > > File ios/crnet/BUILD.gn (right):
> > >
> > >
> https://codereview.chromium.org/2200323003/diff/1/ios/
> crnet/BUILD.gn#newcode71
> > > ios/crnet/BUILD.gn:71: ios_app_bundle("crnet_consumer") {
> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > > Move this target to src/ios/crnet/crnet_consumer/BUILD.gn.
> > >
> > > Done.
> > >
> > >
> https://codereview.chromium.org/2200323003/diff/1/ios/
> crnet/BUILD.gn#newcode93
> > > ios/crnet/BUILD.gn:93: test("crnet_test") {
> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > > Move this target to src/ios/crnet/test/BUILD.gn.
> > >
> > > Done.
> > >
> > >
> >
> https://codereview.chromium.org/2200323003/diff/1/ios/
> crnet/BUILD.gn#newcode101
> > > ios/crnet/BUILD.gn:101: ":crnet_sources",
> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > > ditto about dependency on ":crnet_sources"
> > >
> > > Hrm, this target uses stuff that is not exported from crnet_framework.
> > > I think it should keep using crnet_sources.
> > >
> > >
> >
> https://codereview.chromium.org/2200323003/diff/1/ios/
> crnet/crnet_consumer/crnet_consumer_app_delegate.mm
> > > File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):
> > >
> > >
> >
> https://codereview.chromium.org/2200323003/diff/1/ios/
> crnet/crnet_consumer/crnet_consumer_app_delegate.mm#newcode7
> > > ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:7: #import
> > > "ios/crnet/CrNet.h"
> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
> > > > If you follow my recommendation about using
> crnet_framework+{bind,bundle},
> I
> > > think you will have to revert those #import changes.
> > >
> > > Using crnet_framework+bind results in gn error and using
> crnet_framework+link
> > > still needs path to the header file. Any ideas?
> >
> > Sylvain: ping
>
> Sorry, I did not have time to debug the failure. I'll try to take a look on
> Monday.
>
> https://codereview.chromium.org/2200323003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mef, 2016-08-09 14:58:53]

Thanks a lot, I appreciate that! Don't worry about delay, official builder
is certainly higher priority than this.

On Tue, Aug 9, 2016 at 12:14 AM, Sylvain Defresne <sdefresne@google.com>
wrote:

> I didn't get to this today either (I was trying to fix official builder
> for Chrome on iOS, still failing for a different reason). I'll see if I can
> have a look tomorrow.
> -- Sylvain
>
> On Fri, Aug 5, 2016 at 4:50 PM, <sdefresne@chromium.org> wrote:
>
>> On 2016/08/05 14:34:34, mef wrote:
>> > On 2016/08/03 20:42:41, mef wrote:
>> > > https://codereview.chromium.org/2200323003/diff/1/ios/crnet/BUILD.gn
>> > > File ios/crnet/BUILD.gn (right):
>> > >
>> > >
>> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/
>> BUILD.gn#newcode71
>> > > ios/crnet/BUILD.gn:71: ios_app_bundle("crnet_consumer") {
>> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
>> > > > Move this target to src/ios/crnet/crnet_consumer/BUILD.gn.
>> > >
>> > > Done.
>> > >
>> > >
>> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/
>> BUILD.gn#newcode93
>> > > ios/crnet/BUILD.gn:93: test("crnet_test") {
>> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
>> > > > Move this target to src/ios/crnet/test/BUILD.gn.
>> > >
>> > > Done.
>> > >
>> > >
>> >
>> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/
>> BUILD.gn#newcode101
>> > > ios/crnet/BUILD.gn:101: ":crnet_sources",
>> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
>> > > > ditto about dependency on ":crnet_sources"
>> > >
>> > > Hrm, this target uses stuff that is not exported from crnet_framework.
>> > > I think it should keep using crnet_sources.
>> > >
>> > >
>> >
>> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/
>> crnet_consumer/crnet_consumer_app_delegate.mm
>> > > File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):
>> > >
>> > >
>> >
>> https://codereview.chromium.org/2200323003/diff/1/ios/crnet/
>> crnet_consumer/crnet_consumer_app_delegate.mm#newcode7
>> > > ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:7: #import
>> > > "ios/crnet/CrNet.h"
>> > > On 2016/08/02 at 21:54:11, sdefresne (travelling - slow) wrote:
>> > > > If you follow my recommendation about using
>> crnet_framework+{bind,bundle},
>> I
>> > > think you will have to revert those #import changes.
>> > >
>> > > Using crnet_framework+bind results in gn error and using
>> crnet_framework+link
>> > > still needs path to the header file. Any ideas?
>> >
>> > Sylvain: ping
>>
>> Sorry, I did not have time to debug the failure. I'll try to take a look
>> on
>> Monday.
>>
>> https://codereview.chromium.org/2200323003/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sdefresne, 2016-08-12 20:59:04]

Sorry fixing the official builder and helping with the Xcode 8 transition used
all my time this week.

[mef, 2016-08-12 21:04:34]

On 2016/08/12 20:59:04, sdefresne (OOO Aug 12 - Sep 5) wrote:
> Sorry fixing the official builder and helping with the Xcode 8 transition used
> all my time this week.

Thanks for the update! I'm going to be out next week, but judging by your status
this may have to wait until 9/5.
I appreciate your help, and may try to figure it out on my own, or just wait for
your return.

[mef, 2016-08-26 18:03:55]

David, could you take a look when you have a chance? 
We are currently unable to build crnet due to gn migration.

I've verified that this builds CrNet.framework correctly and it could be used in
external application.

I've changed crnet_consumer to link and bundle with it, but it fails to find it
at runtime. I've verified that it has the same issue with EarlGray.framework, so
there is something missing in crnet_consumer target configuration, but I don't
think that's critical for building crnet.

[droger, 2016-08-29 11:33:02]

I can give you a rubberstamp LGTM for this, the changes look very sensible.

But unfortunately I can't help you with the subtle build issues. I'm just not
familiar with the details and I no longer have a iOS build environment to test
it.

You can land this if you're blocked, and I hope sdefresne will be able to help
you when he's back if you still need to.

[mef, 2016-08-29 13:41:49]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 13:42:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-08-29 13:45:06]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 13:45:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 13:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 13:48:53]

Dry run: Exceeded global retry quota

[mef, 2016-08-29 13:57:06]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 13:57:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 14:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 14:04:56]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[mef, 2016-08-29 15:07:59]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 15:08:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-08-29 15:14:27]

Description was changed from

==========
[Cronet] Add BUILD.gn for legacy ios/CrNet project.

BUG=
==========

to

==========
[Cronet] Add BUILD.gn for legacy ios/CrNet project.

BUG=527059
==========

[commit-bot: I haz the power, 2016-08-29 15:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 15:20:03]

Dry run: Exceeded global retry quota

[mef, 2016-08-29 16:41:56]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 16:51:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-08-29 16:55:28]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 17:05:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-08-29 19:24:39]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 19:41:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-08-29 20:35:21]

The CQ bit was unchecked by mef@chromium.org

[mef, 2016-08-29 20:35:43]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 21:11:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-08-29 22:02:26]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[mef, 2016-08-29 22:18:57]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 22:45:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:18:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mef, 2016-08-30 14:49:19]

On 2016/08/29 11:33:02, droger wrote:
> I can give you a rubberstamp LGTM for this, the changes look very sensible.

Thanks a lot! Could you take one more look? 
It turns out that bots run gn check, and that complains about includes from
dependencies that are not explicitly specified in gn.
I had to add // nogncheck to allow conditional includes of ICU behind 'Use ICU
Alternatives' build flag.

> But unfortunately I can't help you with the subtle build issues. I'm just not
> familiar with the details and I no longer have a iOS build environment to test
> it.
That's fine. Fixing framework reference could wait for Sylvain's return.

> You can land this if you're blocked, and I hope sdefresne will be able to help
> you when he's back if you still need to.

SGTM, so if you could take a look, I'll really appreciate that.

[mef, 2016-08-30 14:49:21]

On 2016/08/29 11:33:02, droger wrote:
> I can give you a rubberstamp LGTM for this, the changes look very sensible.

Thanks a lot! Could you take one more look? 
It turns out that bots run gn check, and that complains about includes from
dependencies that are not explicitly specified in gn.
I had to add // nogncheck to allow conditional includes of ICU behind 'Use ICU
Alternatives' build flag.

> But unfortunately I can't help you with the subtle build issues. I'm just not
> familiar with the details and I no longer have a iOS build environment to test
> it.
That's fine. Fixing framework reference could wait for Sylvain's return.

> You can land this if you're blocked, and I hope sdefresne will be able to help
> you when he's back if you still need to.

SGTM, so if you could take a look, I'll really appreciate that.

[droger, 2016-08-30 15:23:25]

On 2016/08/30 14:49:21, mef wrote:
> Thanks a lot! Could you take one more look? 
> It turns out that bots run gn check, and that complains about includes from
> dependencies that are not explicitly specified in gn.
> I had to add // nogncheck to allow conditional includes of ICU behind 'Use ICU
> Alternatives' build flag.

Yes, as far as I know this is the right thing to do. Still lgtm.

[mef, 2016-08-30 15:50:44]

On 2016/08/30 15:23:25, droger wrote:
> On 2016/08/30 14:49:21, mef wrote:
> > Thanks a lot! Could you take one more look? 
> > It turns out that bots run gn check, and that complains about includes from
> > dependencies that are not explicitly specified in gn.
> > I had to add // nogncheck to allow conditional includes of ICU behind 'Use
ICU
> > Alternatives' build flag.
> 
> Yes, as far as I know this is the right thing to do. Still lgtm.

Thanks!

[mef, 2016-08-30 15:51:00]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2016-08-30 15:51:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 16:18:17]

Description was changed from

==========
[Cronet] Add BUILD.gn for legacy ios/CrNet project.

BUG=527059
==========

to

==========
[Cronet] Add BUILD.gn for legacy ios/CrNet project.

BUG=527059
==========

[commit-bot: I haz the power, 2016-08-30 16:18:19]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-08-30 16:19:57]

Description was changed from

==========
[Cronet] Add BUILD.gn for legacy ios/CrNet project.

BUG=527059
==========

to

==========
[Cronet] Add BUILD.gn for legacy ios/CrNet project.

BUG=527059

Committed: https://crrev.com/6c1a3dd6ee7b9f0ae2b2308e993b8fd94895b252
Cr-Commit-Position: refs/heads/master@{#415312}
==========

[commit-bot: I haz the power, 2016-08-30 16:19:58]

Patchset 8 (id:??) landed as
https://crrev.com/6c1a3dd6ee7b9f0ae2b2308e993b8fd94895b252
Cr-Commit-Position: refs/heads/master@{#415312}