[Cronet] Add CrNet.setUserAgent method on iOS.

[Cronet] Add CrNet.setUserAgent method on iOS.

BUG=632460
Committed: https://crrev.com/cb4f2fe1da0af2d9238d0c8d5f315b824747d103
Cr-Commit-Position: refs/heads/master@{#415662}

[mef, 2016-08-03 22:03:42]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 22:04:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 22:14:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 22:14:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[mef, 2016-08-30 16:14:11]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 16:14:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-08-30 16:16:33]

mef@chromium.org changed reviewers:
+ droger@chromium.org

[mef, 2016-08-30 16:16:34]

Hi David,

PTAL. This should allow CrNet client to fully control User-Agent field.

[commit-bot: I haz the power, 2016-08-30 17:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:17:51]

Dry run: This issue passed the CQ dry run.

[mef, 2016-08-30 20:02:42]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 20:03:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 20:07:18]

Dry run: This issue passed the CQ dry run.

[droger, 2016-08-31 08:52:23]

lgtm

https://codereview.chromium.org/2206283003/diff/40001/ios/crnet/CrNet.h
File ios/crnet/CrNet.h (right):

https://codereview.chromium.org/2206283003/diff/40001/ios/crnet/CrNet.h#newco...
ios/crnet/CrNet.h:46: // Example: Foo/3.0.0.0
This is the same example as setPartialUserAgent above, and it's not clear from
the documentation what is the difference.

Could we improve the doc (at least the example)?

We could also mention that calling setPartialUserAgent undoes previous calls to
setUserAgent and vice-versa.

Or an alternative would be to have the function be:
+ (void)setUserAgent:(NSString*)userAgent partial:(bool)partial;

Then you can remove the other one, or keep it for backward compatibility (and in
this case the comment could be that it does the same thing as calling
setUserAgent with partial=false).

[mef, 2016-08-31 14:49:57]

Thanks a lot!

https://codereview.chromium.org/2206283003/diff/40001/ios/crnet/CrNet.h
File ios/crnet/CrNet.h (right):

https://codereview.chromium.org/2206283003/diff/40001/ios/crnet/CrNet.h#newco...
ios/crnet/CrNet.h:46: // Example: Foo/3.0.0.0
On 2016/08/31 08:52:23, droger wrote:
> This is the same example as setPartialUserAgent above, and it's not clear from
> the documentation what is the difference.
> 
> Could we improve the doc (at least the example)?
> 
> We could also mention that calling setPartialUserAgent undoes previous calls
to
> setUserAgent and vice-versa.
> 
> Or an alternative would be to have the function be:
> + (void)setUserAgent:(NSString*)userAgent partial:(bool)partial;
> 
> Then you can remove the other one, or keep it for backward compatibility (and
in
> this case the comment could be that it does the same thing as calling
> setUserAgent with partial=false).

Great suggestion! Done.

[mef, 2016-08-31 14:50:32]

The CQ bit was checked by mef@chromium.org

[mef, 2016-08-31 14:50:33]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/2206283003/#ps60001
(title: "Implement David's suggestion.")

[commit-bot: I haz the power, 2016-08-31 14:50:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 15:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 15:03:31]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[mef, 2016-08-31 15:15:42]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 15:16:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 16:08:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 16:08:29]

Dry run: This issue passed the CQ dry run.

[mef, 2016-08-31 16:50:32]

The CQ bit was checked by mef@chromium.org

[mef, 2016-08-31 16:50:32]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/2206283003/#ps80001
(title: "Unmark setPartialUserAgent as deprecated.")

[commit-bot: I haz the power, 2016-08-31 16:50:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 16:55:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-31 16:59:05]

Description was changed from

==========
[Cronet] Add CrNet.setUserAgent method on iOS.

BUG=632460
==========

to

==========
[Cronet] Add CrNet.setUserAgent method on iOS.

BUG=632460

Committed: https://crrev.com/cb4f2fe1da0af2d9238d0c8d5f315b824747d103
Cr-Commit-Position: refs/heads/master@{#415662}
==========

[commit-bot: I haz the power, 2016-08-31 16:59:07]

Patchset 5 (id:??) landed as
https://crrev.com/cb4f2fe1da0af2d9238d0c8d5f315b824747d103
Cr-Commit-Position: refs/heads/master@{#415662}