Move consumeImage to CSSPropertyParserHelpers

Move consumeImage to CSSPropertyParserHelpers

Move consumeImage to CSSPropertyParserHelpers along with
a lot of supporting code. Also rewrite consumeCursor
to start using consumeImage; as a nice side effect the
consumeCursor code becomes shorter and easier to read.

Committed: https://crrev.com/daafae37c42d449d5279f2e98255e3c9796e939e
Cr-Commit-Position: refs/heads/master@{#410369}

[rwlbuis, 2016-08-02 21:33:11]

Patchset #2 (id:20001) has been deleted

[rwlbuis, 2016-08-02 22:16:09]

Description was changed from

==========
consumeImage WIP

BUG=
==========

to

==========
Move consumeImage to CSSPropertyParserHelpers

Move consumeImage to CSSPropertyParserHelpers along with
a lot of supporting code. Also rewrite consumeCursor
to start using consumeImage; as a nice side effect the
consumeCursor code becomes shorter and easier to read.
==========

[rwlbuis, 2016-08-03 00:15:43]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-08-03 00:15:43]

PTAL. I noticed that webkit does allow image set (but not generated images) for
the cursor property, like we do.

[Timothy Loh, 2016-08-05 00:44:22]

lgtm

On 2016/08/03 00:15:43, rwlbuis wrote:
> PTAL. I noticed that webkit does allow image set (but not generated images)
for
> the cursor property, like we do.

Maybe we could count this behavior and see if we could remove it. In the spec it
takes a <url> not an <image>.

https://drafts.csswg.org/css-ui-3/#cursor

[rwlbuis, 2016-08-05 17:35:32]

On 2016/08/05 00:44:22, Timothy Loh wrote:
> lgtm
> 
> On 2016/08/03 00:15:43, rwlbuis wrote:
> > PTAL. I noticed that webkit does allow image set (but not generated images)
> for
> > the cursor property, like we do.
> 
> Maybe we could count this behavior and see if we could remove it. In the spec
it
> takes a <url> not an <image>.
> 
> https://drafts.csswg.org/css-ui-3/#cursor

True. But there is alsoe this section
(https://www.w3.org/TR/css4-images/#image-type):
"An ‘<image>’ can be used in many CSS properties, including the
‘background-image’, ‘list-style-image’, ‘cursor’ properties [CSS21] (where it
replaces the ‘<url>’ component in the property's value)."

Anyway I'll gladly add a counter, just let me know.

[rwlbuis, 2016-08-05 17:35:36]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-08-05 17:36:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:14:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:14:13]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[rwlbuis, 2016-08-05 18:23:00]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-08-05 18:23:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:52:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:52:49]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Timothy Loh, 2016-08-08 00:26:38]

On 2016/08/05 17:35:32, rwlbuis wrote:
> On 2016/08/05 00:44:22, Timothy Loh wrote:
> > lgtm
> > 
> > On 2016/08/03 00:15:43, rwlbuis wrote:
> > > PTAL. I noticed that webkit does allow image set (but not generated
images)
> > for
> > > the cursor property, like we do.
> > 
> > Maybe we could count this behavior and see if we could remove it. In the
spec
> it
> > takes a <url> not an <image>.
> > 
> > https://drafts.csswg.org/css-ui-3/#cursor
> 
> True. But there is alsoe this section
> (https://www.w3.org/TR/css4-images/#image-type):
> "An ‘<image>’ can be used in many CSS properties, including the
> ‘background-image’, ‘list-style-image’, ‘cursor’ properties [CSS21] (where it
> replaces the ‘<url>’ component in the property's value)."
> 
> Anyway I'll gladly add a counter, just let me know.

Ah, I hadn't seen this bit of spec text. I guess there's no point to add a
counter then.

[rwlbuis, 2016-08-08 14:22:02]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-08-08 14:22:02]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2200313002/#ps60001
(title: "Rename enum")

[commit-bot: I haz the power, 2016-08-08 14:22:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 14:29:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:29:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[rwlbuis, 2016-08-08 15:01:33]

Patchset #3 (id:60001) has been deleted

[rwlbuis, 2016-08-08 15:02:10]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-08-08 15:02:10]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2200313002/#ps80001
(title: "Rename enum")

[commit-bot: I haz the power, 2016-08-08 15:02:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:07:44]

Description was changed from

==========
Move consumeImage to CSSPropertyParserHelpers

Move consumeImage to CSSPropertyParserHelpers along with
a lot of supporting code. Also rewrite consumeCursor
to start using consumeImage; as a nice side effect the
consumeCursor code becomes shorter and easier to read.
==========

to

==========
Move consumeImage to CSSPropertyParserHelpers

Move consumeImage to CSSPropertyParserHelpers along with
a lot of supporting code. Also rewrite consumeCursor
to start using consumeImage; as a nice side effect the
consumeCursor code becomes shorter and easier to read.
==========

[commit-bot: I haz the power, 2016-08-08 16:07:46]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-08-08 16:10:24]

Description was changed from

==========
Move consumeImage to CSSPropertyParserHelpers

Move consumeImage to CSSPropertyParserHelpers along with
a lot of supporting code. Also rewrite consumeCursor
to start using consumeImage; as a nice side effect the
consumeCursor code becomes shorter and easier to read.
==========

to

==========
Move consumeImage to CSSPropertyParserHelpers

Move consumeImage to CSSPropertyParserHelpers along with
a lot of supporting code. Also rewrite consumeCursor
to start using consumeImage; as a nice side effect the
consumeCursor code becomes shorter and easier to read.

Committed: https://crrev.com/daafae37c42d449d5279f2e98255e3c9796e939e
Cr-Commit-Position: refs/heads/master@{#410369}
==========

[commit-bot: I haz the power, 2016-08-08 16:10:26]

Patchset 3 (id:??) landed as
https://crrev.com/daafae37c42d449d5279f2e98255e3c9796e939e
Cr-Commit-Position: refs/heads/master@{#410369}