third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h - Issue 2200313002: Move consumeImage to CSSPropertyParserHelpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

Issue 2200313002: Move consumeImage to CSSPropertyParserHelpers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename enum Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

index 17b4ff0866d39771406e33481457aa62d4b8a9d4..f777c391fff5955d2af8dd5fbb43e60620a0fd00 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h

@@ -59,7 +59,13 @@ CSSValuePair* consumePosition(CSSParserTokenRange&, CSSParserMode, UnitlessQuirk

bool consumePosition(CSSParserTokenRange&, CSSParserMode, UnitlessQuirk, CSSValue*& resultX, CSSValue*& resultY);

bool consumeOneOrTwoValuedPosition(CSSParserTokenRange&, CSSParserMode, UnitlessQuirk, CSSValue*& resultX, CSSValue*& resultY);

-// TODO(timloh): Move across consumeImage

+enum class ConsumeGeneratedImage {

+ Allow,

+ Forbid

+};

+CSSValue* consumeImage(CSSParserTokenRange&, CSSParserContext, ConsumeGeneratedImage = ConsumeGeneratedImage::Allow);

+CSSValue* consumeImageOrNone(CSSParserTokenRange&, CSSParserContext);

// Template implementations are at the bottom of the file for readability.