third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2200303003: Remove v8CallOrCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2200303003: Remove v8CallOrCrash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/streams/ReadableStreamOperations.cpp ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp ('k') | third_party/WebKit/Source/web/InspectorOverlay.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 78328c47032d9242c0b8e7f8a0efc21da93bfeef..ec3b48206e6f0da15963f01768e62ad4a3a33ec1 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -6412,9 +6412,9 @@ void WebGLRenderingContextBase::preserveObjectWrapper(ScriptState* scriptState,

v8::Local<v8::Array> localCache = persistentCache->newLocal(isolate);

if (targetObject) {

- v8CallOrCrash(localCache->Set(scriptState->context(), index, targetObject->mainWorldWrapper(isolate)));

+ localCache->Set(scriptState->context(), index, targetObject->mainWorldWrapper(isolate)).ToChecked();

} else {

- v8CallOrCrash(localCache->Set(scriptState->context(), index, v8::Null(isolate)));

+ localCache->Set(scriptState->context(), index, v8::Null(isolate)).ToChecked();

}