Disallow assigning null to non-nullable variables

Disallow assigning null to non-nullable variables

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/3237d789d1a6bac1c0f6bd9cabcb9e0f5124637a

[stanm, 2016-08-02 23:42:31]

stanm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-08-03 18:06:56]

lgtm

https://codereview.chromium.org/2200263004/diff/60001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (right):

https://codereview.chromium.org/2200263004/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:773: return
"${type?.element?.library?.identifier},$type";
.source.uri ?

https://codereview.chromium.org/2200263004/diff/60001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/non_null_checker_test.dart (right):

https://codereview.chromium.org/2200263004/diff/60001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/non_null_checker_test.dart:53: addFile('''int
x;''');
if it's a 1-liner, you can use single quotes. The triple quotes are intended to
help with newlines

[stanm, 2016-08-03 18:46:21]

https://codereview.chromium.org/2200263004/diff/60001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (right):

https://codereview.chromium.org/2200263004/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:773: return
"${type?.element?.library?.identifier},$type";
On 2016/08/03 18:06:56, John Messerly wrote:
> .source.uri ?

Done.

https://codereview.chromium.org/2200263004/diff/60001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/non_null_checker_test.dart (right):

https://codereview.chromium.org/2200263004/diff/60001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/non_null_checker_test.dart:53: addFile('''int
x;''');
On 2016/08/03 18:06:56, John Messerly wrote:
> if it's a 1-liner, you can use single quotes. The triple quotes are intended
to
> help with newlines

I was too lazy to think and just copied code over :)

[stanm, 2016-08-03 18:47:17]

Description was changed from

==========
Disallow assigning null to non-nullable variables

BUG=
==========

to

==========
Disallow assigning null to non-nullable variables

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3237d789d1a6bac1c0f6bd9cabcb9e0f5124637a
==========

[stanm, 2016-08-03 18:47:18]

Committed patchset #5 (id:80001) manually as
3237d789d1a6bac1c0f6bd9cabcb9e0f5124637a (presubmit successful).