Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2664)

Unified Diff: pkg/analyzer/test/src/task/strong/non_null_checker_test.dart

Issue 2200263004: Disallow assigning null to non-nullable variables (Closed) Base URL: https://github.com/dart-lang/sdk@master
Patch Set: Address lgtm comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/strong/checker.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/strong/non_null_checker_test.dart
diff --git a/pkg/analyzer/test/src/task/strong/non_null_checker_test.dart b/pkg/analyzer/test/src/task/strong/non_null_checker_test.dart
index 7b9b933973941f16ec1a328330c89e10378b925a..ac056c2a5433a20a7011ff2bba3aca361027e3f7 100644
--- a/pkg/analyzer/test/src/task/strong/non_null_checker_test.dart
+++ b/pkg/analyzer/test/src/task/strong/non_null_checker_test.dart
@@ -45,13 +45,22 @@ main() {
void test_nullableTypes() {
// By default x can be set to null.
- checkFile('''int x = null;''');
+ checkFile('int x = null;');
}
- @failingTest
void test_nonnullableTypes() {
// If `int`s are non-nullable, then this code should throw an error.
- addFile('''int x = /*error:INVALID_ASSIGNMENT*/null;''');
+ addFile('int x;');
+ addFile('int x = /*error:INVALID_ASSIGNMENT*/null;');
+ addFile('int x = 0;');
+ addFile('''
+int x = 0;
+
+main() {
+ x = 1;
+ x = /*error:INVALID_ASSIGNMENT*/null;
+}
+''');
check(nonnullableTypes: <String>['dart:core,int']);
}
}
« no previous file with comments | « pkg/analyzer/lib/src/task/strong/checker.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698