asm.js. Adds support for clz32 in asm.js.

[wasm] asm.js. Adds support for clz32 in asm.js.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203

Committed: https://crrev.com/3fa56f2bb2c2f2a072ae457f5d7439bf930f0c9f
Cr-Commit-Position: refs/heads/master@{#38259}

[John, 2016-08-02 17:59:41]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 17:59:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-08-02 18:00:12]

jpp@chromium.org changed reviewers:
+ aseemgarg@chromium.org, bradnelson@chromium.org

[John, 2016-08-02 18:00:12]

jpp@chromium.org changed reviewers:
+ aseemgarg@chromium.org, bradnelson@chromium.org

[bradnelson, 2016-08-02 18:05:15]

Description was changed from

==========
asm.js. Adds support for clz32 in asm.js.

BUG=
==========

to

==========
[wasm] asm.js. Adds support for clz32 in asm.js.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
==========

[bradnelson, 2016-08-02 18:06:43]

I added the tracking bug and [wasm] prefix to the CL description.
lgtm, other than one comment.

https://codereview.chromium.org/2200213002/diff/20001/src/asmjs/asm-typer.cc
File src/asmjs/asm-typer.cc (right):

https://codereview.chromium.org/2200213002/diff/20001/src/asmjs/asm-typer.cc#...
src/asmjs/asm-typer.cc:254: {"clz32", kMathClz32, i2s},  // NOTE: clz32 should
return fixnum.
Maybe describe why we're not, for someone missing the context?

[John, 2016-08-02 18:10:54]

https://codereview.chromium.org/2200213002/diff/20001/src/asmjs/asm-typer.cc
File src/asmjs/asm-typer.cc (right):

https://codereview.chromium.org/2200213002/diff/20001/src/asmjs/asm-typer.cc#...
src/asmjs/asm-typer.cc:254: {"clz32", kMathClz32, i2s},  // NOTE: clz32 should
return fixnum.
On 2016/08/02 18:06:43, bradnelson wrote:
> Maybe describe why we're not, for someone missing the context?

Done.

[bradn, 2016-08-02 18:12:09]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-08-02 18:12:09]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-08-02 18:12:09]

lgtm

[bradn, 2016-08-02 18:12:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2200213002/#ps40001
(title: "addresses comment")

[commit-bot: I haz the power, 2016-08-02 18:12:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 18:32:39]

Description was changed from

==========
[wasm] asm.js. Adds support for clz32 in asm.js.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
==========

to

==========
[wasm] asm.js. Adds support for clz32 in asm.js.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
==========

[commit-bot: I haz the power, 2016-08-02 18:32:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-02 18:37:05]

Description was changed from

==========
[wasm] asm.js. Adds support for clz32 in asm.js.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
==========

to

==========
[wasm] asm.js. Adds support for clz32 in asm.js.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203

Committed: https://crrev.com/3fa56f2bb2c2f2a072ae457f5d7439bf930f0c9f
Cr-Commit-Position: refs/heads/master@{#38259}
==========

[commit-bot: I haz the power, 2016-08-02 18:37:06]

Patchset 3 (id:??) landed as
https://crrev.com/3fa56f2bb2c2f2a072ae457f5d7439bf930f0c9f
Cr-Commit-Position: refs/heads/master@{#38259}