asm.js. Adds support for clz32 in asm.js.

src/asmjs/asm-typer.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/asmjs/asm-typer.h"
 
 #include <algorithm>
 #include <limits>
 #include <memory>
 #include <string>
@@ skipping 160 matching lines @@
   auto* f = AsmType::Float();
   auto* fq = AsmType::FloatQ();
   auto* fq2f = AsmType::Function(zone_, f);
   fq2f->AsFunctionType()->AddArgument(fq);
 
   auto* s = AsmType::Signed();
   auto* s2s = AsmType::Function(zone_, s);
   s2s->AsFunctionType()->AddArgument(s);
 
   auto* i = AsmType::Int();
+  auto* i2s = AsmType::Function(zone_, s);
+  i2s->AsFunctionType()->AddArgument(i);
+
   auto* ii2s = AsmType::Function(zone_, s);
   ii2s->AsFunctionType()->AddArgument(i);
   ii2s->AsFunctionType()->AddArgument(i);
 
   auto* minmax_d = AsmType::MinMaxType(zone_, d, d);
   // *VIOLATION* The float variant is not part of the spec, but firefox accepts
   // it.
   auto* minmax_f = AsmType::MinMaxType(zone_, f, f);
   auto* minmax_i = AsmType::MinMaxType(zone_, s, i);
   auto* minmax = AsmType::OverloadedFunction(zone_);
@@ skipping 50 matching lines @@
       {"PI", kMathPI, d},
       {"E", kMathE, d},
       {"LN2", kMathLN2, d},
       {"LN10", kMathLN10, d},
       {"LOG2E", kMathLOG2E, d},
       {"LOG10E", kMathLOG10E, d},
       {"SQRT2", kMathSQRT2, d},
       {"SQRT1_2", kMathSQRT1_2, d},
       {"imul", kMathImul, ii2s},
       {"abs", kMathAbs, abs},
+      {"clz32", kMathClz32, i2s},  // NOTE: clz32 should return fixnum.

[bradnelson, 2016/08/02 18:06:43]

Maybe describe why we're not, for someone missing the context?

[John, 2016/08/02 18:10:54]

Done.

       {"ceil", kMathCeil, ceil},
       {"floor", kMathFloor, floor},
       {"fround", kMathFround, fround},
       {"pow", kMathPow, dqdq2d},
       {"exp", kMathExp, dq2d},
       {"log", kMathLog, dq2d},
       {"min", kMathMin, minmax},
       {"max", kMathMax, minmax},
       {"sqrt", kMathSqrt, sqrt},
       {"cos", kMathCos, dq2d},
@@ skipping 2476 matching lines @@
     return true;
   }
 
   *error_message = typer.error_message();
   return false;
 }
 
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8