Simplify CustomElementScheduler by passing the enum for callback type directly.

Simplify CustomElementScheduler by passing the enum for callback type directly.

Instead of having one scheduling function per callback type, we can use
a single shared one except for the attribute callback case.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170500

[dglazkov, 2014-03-31 22:45:22]

lgtm

[esprehn, 2014-03-31 22:48:42]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-31 22:48:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/220013003/1

[dominicc (has gone to gerrit), 2014-03-31 23:15:36]

What does this buy us? It seems opportunity for fragility as you noted with your
ASSERT-not-attribute changed.

I like the hasCallback() thing though.

[commit-bot: I haz the power, 2014-04-01 00:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 00:04:24]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[esprehn, 2014-04-01 00:10:27]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-04-01 00:10:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/220013003/1

[esprehn, 2014-04-01 00:11:10]

On 2014/03/31 23:15:36, dominicc wrote:
> What does this buy us? It seems opportunity for fragility as you noted with
your
> ASSERT-not-attribute changed.
> 
> I like the hasCallback() thing though.

Less code duplication. I have a series of patches that will eventually remove
the CustomElementScheduler entirely. I also want to get rid of all these statics
and singletons.

[commit-bot: I haz the power, 2014-04-01 01:29:03]

Change committed as 170500