Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: Source/core/dom/custom/CustomElementCallbackInvocation.cpp

Issue 220013003: Simplify CustomElementScheduler by passing the enum for callback type directly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 } 100 }
101 101
102 private: 102 private:
103 virtual void dispatch(Element*) OVERRIDE; 103 virtual void dispatch(Element*) OVERRIDE;
104 virtual bool isCreated() const OVERRIDE { return true; } 104 virtual bool isCreated() const OVERRIDE { return true; }
105 }; 105 };
106 106
107 void CreatedInvocation::dispatch(Element* element) 107 void CreatedInvocation::dispatch(Element* element)
108 { 108 {
109 if (element->inDocument() && element->document().domWindow()) 109 if (element->inDocument() && element->document().domWindow())
110 CustomElementScheduler::scheduleAttachedCallback(callbacks(), element); 110 CustomElementScheduler::scheduleCallback(callbacks(), element, CustomEle mentLifecycleCallbacks::Attached);
111 callbacks()->created(element); 111 callbacks()->created(element);
112 } 112 }
113 113
114 PassOwnPtr<CustomElementCallbackInvocation> CustomElementCallbackInvocation::cre ateInvocation(PassRefPtr<CustomElementLifecycleCallbacks> callbacks, CustomEleme ntLifecycleCallbacks::CallbackType which) 114 PassOwnPtr<CustomElementCallbackInvocation> CustomElementCallbackInvocation::cre ateInvocation(PassRefPtr<CustomElementLifecycleCallbacks> callbacks, CustomEleme ntLifecycleCallbacks::CallbackType which)
115 { 115 {
116 switch (which) { 116 switch (which) {
117 case CustomElementLifecycleCallbacks::Created: 117 case CustomElementLifecycleCallbacks::Created:
118 return adoptPtr(new CreatedInvocation(callbacks)); 118 return adoptPtr(new CreatedInvocation(callbacks));
119 119
120 case CustomElementLifecycleCallbacks::Attached: 120 case CustomElementLifecycleCallbacks::Attached:
121 case CustomElementLifecycleCallbacks::Detached: 121 case CustomElementLifecycleCallbacks::Detached:
122 return adoptPtr(new AttachedDetachedInvocation(callbacks, which)); 122 return adoptPtr(new AttachedDetachedInvocation(callbacks, which));
123 default: 123 default:
124 ASSERT_NOT_REACHED(); 124 ASSERT_NOT_REACHED();
125 return PassOwnPtr<CustomElementCallbackInvocation>(); 125 return PassOwnPtr<CustomElementCallbackInvocation>();
126 } 126 }
127 } 127 }
128 128
129 PassOwnPtr<CustomElementCallbackInvocation> CustomElementCallbackInvocation::cre ateAttributeChangedInvocation(PassRefPtr<CustomElementLifecycleCallbacks> callba cks, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue) 129 PassOwnPtr<CustomElementCallbackInvocation> CustomElementCallbackInvocation::cre ateAttributeChangedInvocation(PassRefPtr<CustomElementLifecycleCallbacks> callba cks, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue)
130 { 130 {
131 return adoptPtr(new AttributeChangedInvocation(callbacks, name, oldValue, ne wValue)); 131 return adoptPtr(new AttributeChangedInvocation(callbacks, name, oldValue, ne wValue));
132 } 132 }
133 133
134 } // namespace WebCore 134 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/custom/CustomElement.cpp ('k') | Source/core/dom/custom/CustomElementLifecycleCallbacks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698