Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2200123002: Add option to not generate VS projects for targets deps (Closed)

Created:
4 years, 4 months ago by Tomasz Moniuszko
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add option to not generate VS projects for targets deps BUG=589099 Committed: https://crrev.com/64edbcf758a9c60fbd1679460e1fd69db29998f7 Cr-Commit-Position: refs/heads/master@{#409489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -28 lines) Patch
M tools/gn/command_gen.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M tools/gn/docs/reference.md View 9 chunks +48 lines, -14 lines 0 comments Download
M tools/gn/visual_studio_writer.h View 1 chunk +7 lines, -5 lines 0 comments Download
M tools/gn/visual_studio_writer.cc View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tomasz Moniuszko
4 years, 4 months ago (2016-08-02 13:12:49 UTC) #2
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-03 00:23:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2200123002/1
4 years, 4 months ago (2016-08-03 10:53:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 11:34:35 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 11:36:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64edbcf758a9c60fbd1679460e1fd69db29998f7
Cr-Commit-Position: refs/heads/master@{#409489}

Powered by Google App Engine
This is Rietveld 408576698