Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/gn/visual_studio_writer.cc

Issue 2200123002: Add option to not generate VS projects for targets deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/visual_studio_writer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer.cc
diff --git a/tools/gn/visual_studio_writer.cc b/tools/gn/visual_studio_writer.cc
index fb6d923db0a02ec61d669ca8c1d33db62294defc..b6fe3c0596f5805fb5133cd204e17cdf596b6036 100644
--- a/tools/gn/visual_studio_writer.cc
+++ b/tools/gn/visual_studio_writer.cc
@@ -167,22 +167,26 @@ base::StringPiece FindParentDir(const std::string* path) {
bool FilterTargets(const BuildSettings* build_settings,
const Builder& builder,
- const std::string& dir_filters,
+ const std::string& filters,
+ bool no_deps,
std::vector<const Target*>* targets,
Err* err) {
- if (dir_filters.empty()) {
+ if (filters.empty()) {
*targets = builder.GetAllResolvedTargets();
return true;
}
- std::vector<LabelPattern> filters;
- if (!commands::FilterPatternsFromString(build_settings, dir_filters, &filters,
+ std::vector<LabelPattern> patterns;
+ if (!commands::FilterPatternsFromString(build_settings, filters, &patterns,
err))
return false;
- commands::FilterTargetsByPatterns(builder.GetAllResolvedTargets(), filters,
+ commands::FilterTargetsByPatterns(builder.GetAllResolvedTargets(), patterns,
targets);
+ if (no_deps)
+ return true;
+
std::set<Label> labels;
std::queue<const Target*> to_process;
for (const Target* target : *targets) {
@@ -272,10 +276,11 @@ bool VisualStudioWriter::RunAndWriteFiles(const BuildSettings* build_settings,
const Builder& builder,
Version version,
const std::string& sln_name,
- const std::string& dir_filters,
+ const std::string& filters,
+ bool no_deps,
Err* err) {
std::vector<const Target*> targets;
- if (!FilterTargets(build_settings, builder, dir_filters, &targets, err))
+ if (!FilterTargets(build_settings, builder, filters, no_deps, &targets, err))
return false;
const char* config_platform = "Win32";
« no previous file with comments | « tools/gn/visual_studio_writer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698