[Tracing] V8 Tracing Controller - Fix async trace event bug

[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=v8:5261
Committed: https://crrev.com/94ad974df8434844ea179f0a57b52b94dc7bc760
Cr-Commit-Position: refs/heads/master@{#38331}

[rskang, 2016-08-02 21:51:21]

The CQ bit was checked by rskang@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 21:51:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 22:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 22:09:10]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/11702)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[rskang, 2016-08-02 22:45:58]

The CQ bit was checked by rskang@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:46:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 23:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 23:07:33]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/11706)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[rskang, 2016-08-02 23:40:14]

The CQ bit was checked by rskang@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 23:40:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 00:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 00:16:09]

Dry run: This issue passed the CQ dry run.

[rskang, 2016-08-03 00:49:43]

rskang@google.com changed reviewers:
+ fmeawad@google.com, lpy@chromium.org, mattloring@google.com

[rskang, 2016-08-03 00:49:43]

JSONTraceWriter output for async trace events had a bug:

Usage of hex IO manipulator for async event IDs corrupts future decimal integer
outputs.

This bug wasn't caught by tests as async events weren't tested previously. This
CL adds a test as well as the fix for it.

[mattloring, 2016-08-03 02:48:25]

lgtm

[mattloring, 2016-08-03 02:48:27]

lgtm

[fmeawad, 2016-08-03 06:41:07]

On 2016/08/03 02:48:27, mattloring wrote:
> lgtm

Please create a bug, and set BUG=v8:...

[fmeawad, 2016-08-03 06:48:02]

fmeawad@chromium.org changed reviewers:
+ fmeawad@chromium.org

[fmeawad, 2016-08-03 06:48:03]

LGTM with comments.

https://codereview.chromium.org/2200113003/diff/40001/test/cctest/libplatform...
File test/cctest/libplatform/test-tracing.cc (right):

https://codereview.chromium.org/2200113003/diff/40001/test/cctest/libplatform...
test/cctest/libplatform/test-tracing.cc:312: TEST(TestAsyncTraceEvent) {
All test names are based on Classes and not trace event types, can you merge the
test code to be part of the TraceWriter test?

https://codereview.chromium.org/2200113003/diff/40001/test/cctest/libplatform...
test/cctest/libplatform/test-tracing.cc:335:
TRACE_EVENT_NESTABLE_ASYNC_BEGIN0("v8", "Test2", p);
Can you add an END for these trace events?

[lpy, 2016-08-03 06:49:32]

Also keep 80-column in CL description please.

[rskang, 2016-08-03 20:05:04]

The CQ bit was checked by rskang@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:05:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rskang, 2016-08-03 20:05:57]

Description was changed from

==========
[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=
==========

to

==========
[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=v8:5261
==========

[rskang, 2016-08-03 20:05:58]

Description was changed from

==========
[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=
==========

to

==========
[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=v8:5261
==========

[commit-bot: I haz the power, 2016-08-03 20:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:23:26]

Dry run: This issue passed the CQ dry run.

[rskang, 2016-08-03 20:41:46]

Fixed 80-line character limit for CL description.
Added BUG id.

https://codereview.chromium.org/2200113003/diff/40001/test/cctest/libplatform...
File test/cctest/libplatform/test-tracing.cc (right):

https://codereview.chromium.org/2200113003/diff/40001/test/cctest/libplatform...
test/cctest/libplatform/test-tracing.cc:312: TEST(TestAsyncTraceEvent) {
On 2016/08/03 06:48:02, fmeawad wrote:
> All test names are based on Classes and not trace event types, can you merge
the
> test code to be part of the TraceWriter test?

Done.

https://codereview.chromium.org/2200113003/diff/40001/test/cctest/libplatform...
test/cctest/libplatform/test-tracing.cc:335:
TRACE_EVENT_NESTABLE_ASYNC_BEGIN0("v8", "Test2", p);
On 2016/08/03 06:48:02, fmeawad wrote:
> Can you add an END for these trace events?

Not needed after merging into TestJSONTraceWriter.

[mattloring, 2016-08-03 20:50:15]

mattloring@google.com changed reviewers:
+ yangguo@chromium.org

[rskang, 2016-08-04 00:57:37]

Added @Yang to reviewers.

[Yang, 2016-08-04 06:58:24]

On 2016/08/04 00:57:37, rskang wrote:
> Added @Yang to reviewers.

lgtm.

[rskang, 2016-08-04 08:39:11]

The CQ bit was checked by rskang@google.com

[rskang, 2016-08-04 08:39:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattloring@google.com, fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/2200113003/#ps60001
(title: "Merge async test as part of TestJSONTraceWriter")

[commit-bot: I haz the power, 2016-08-04 08:39:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 08:48:26]

Description was changed from

==========
[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=v8:5261
==========

to

==========
[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=v8:5261
==========

[commit-bot: I haz the power, 2016-08-04 08:48:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-04 08:49:27]

Description was changed from

==========
[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=v8:5261
==========

to

==========
[Tracing] V8 Tracing Controller - Fix async trace event bug

Usage of hex IO manipulator for async event IDs corrupts future decimal number
outputs.

BUG=v8:5261

Committed: https://crrev.com/94ad974df8434844ea179f0a57b52b94dc7bc760
Cr-Commit-Position: refs/heads/master@{#38331}
==========

[commit-bot: I haz the power, 2016-08-04 08:49:28]

Patchset 4 (id:??) landed as
https://crrev.com/94ad974df8434844ea179f0a57b52b94dc7bc760
Cr-Commit-Position: refs/heads/master@{#38331}