[Tracing] V8 Tracing Controller - Fix async trace event bug

test/cctest/libplatform/test-tracing.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include <limits>
 
 #include "include/libplatform/v8-tracing.h"
 #include "src/tracing/trace-event.h"
 #include "test/cctest/cctest.h"
 
 namespace v8 {
@@ skipping 291 matching lines @@
 
   CHECK_EQ(all_names[20], "INIT");
   CHECK_EQ(all_names[21], "INIT");
   CHECK_EQ(all_args[21], "\"INIT\":\"INIT\"");
   CHECK_EQ(all_names[22], "INIT");
   CHECK_EQ(all_args[22], "\"INIT\":\"INIT\",\"INIT\":\"INIT\"");
 
   i::V8::SetPlatformForTesting(old_platform);
 }
 
+TEST(TestAsyncTraceEvent) {

[fmeawad, 2016/08/03 06:48:02]

All test names are based on Classes and not trace event types, can you merge the
test code to be part of the TraceWriter test?

[rskang, 2016/08/03 20:41:45]

Done.

+  std::ostringstream stream;
+  v8::Platform* old_platform = i::V8::GetCurrentPlatform();
+  v8::Platform* default_platform = v8::platform::CreateDefaultPlatform();
+  i::V8::SetPlatformForTesting(default_platform);
+
+  uint64_t x = 0xdeadbeef5;
+  uint64_t* p = &x;
+
+  // Create a scope for the tracing controller to terminate the trace writer.
+  {
+    TracingController tracing_controller;
+    platform::SetTracingController(default_platform, &tracing_controller);
+    TraceWriter* writer = TraceWriter::CreateJSONTraceWriter(stream);
+
+    TraceBuffer* ring_buffer =
+        TraceBuffer::CreateTraceBufferRingBuffer(1, writer);
+    tracing_controller.Initialize(ring_buffer);
+    TraceConfig* trace_config = new TraceConfig();
+    trace_config->AddIncludedCategory("v8");
+    tracing_controller.StartTracing(trace_config);
+
+    TRACE_EVENT_NESTABLE_ASYNC_BEGIN0("v8", "Test1", x);
+    TRACE_EVENT_NESTABLE_ASYNC_BEGIN0("v8", "Test2", p);

[fmeawad, 2016/08/03 06:48:02]

Can you add an END for these trace events?

[rskang, 2016/08/03 20:41:45]

Not needed after merging into TestJSONTraceWriter.

+
+    tracing_controller.StopTracing();
+  }
+
+  std::string trace_str = stream.str();
+
+  std::vector<std::string> all_ids, all_ts;
+  GetJSONStrings(all_ids, trace_str, "\"id\"", "\"", "\"");
+  GetJSONStrings(all_ts, trace_str, "\"ts\"", ":", ",");
+
+  CHECK_EQ(all_ids.size(), 2);
+  CHECK_EQ(all_ids[0], "0xdeadbeef5");
+  std::ostringstream pointer_stream;
+  pointer_stream << "0x" << std::hex << reinterpret_cast<uint64_t>(&x);
+  CHECK_EQ(all_ids[1], pointer_stream.str());
+
+  // Ensure decimal values did not get corrupted due to hex ids.
+  CHECK(std::all_of(all_ts[1].begin() + 1, all_ts[1].end() - 1, isdigit));
+
+  i::V8::SetPlatformForTesting(old_platform);
+}
+
 }  // namespace tracing
 }  // namespace platform
 }  // namespace v8