Add generic PaletteDelegate code.

Add generic PaletteDelegate code.

The delegate methods will be populated in later CLs as needed. This CL just
provides the delegate structure.

BUG=616112
Committed: https://crrev.com/0f4fa6ef10afabc0f4b889a3175b4aa0c8d715cf
Cr-Commit-Position: refs/heads/master@{#410132}

[jdufault, 2016-08-01 21:58:14]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 21:58:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 22:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:22:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniel Erat, 2016-08-02 21:35:01]

derat@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2016-08-02 21:35:01]

https://codereview.chromium.org/2199993002/diff/1/ash/common/shell_delegate.h
File ash/common/shell_delegate.h (right):

https://codereview.chromium.org/2199993002/diff/1/ash/common/shell_delegate.h...
ash/common/shell_delegate.h:128: virtual PaletteDelegate*
CreatePaletteDelegate() = 0;
how about returning std::unique_ptr<PaletteDelegate> so the ownership transfer
is clear? note that the next method already does this.

[jdufault, 2016-08-04 23:55:18]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[jdufault, 2016-08-04 23:55:29]

https://codereview.chromium.org/2199993002/diff/1/ash/common/shell_delegate.h
File ash/common/shell_delegate.h (right):

https://codereview.chromium.org/2199993002/diff/1/ash/common/shell_delegate.h...
ash/common/shell_delegate.h:128: virtual PaletteDelegate*
CreatePaletteDelegate() = 0;
On 2016/08/02 21:35:01, Daniel Erat wrote:
> how about returning std::unique_ptr<PaletteDelegate> so the ownership transfer
> is clear? note that the next method already does this.

Done.

[commit-bot: I haz the power, 2016-08-04 23:55:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 23:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 23:57:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jdufault, 2016-08-05 00:06:53]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:07:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 00:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 00:18:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2016-08-05 00:42:51]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:43:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 00:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 00:54:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniel Erat, 2016-08-05 15:48:52]

lgtm with a few nits. thanks!

https://codereview.chromium.org/2199993002/diff/60001/ash/common/palette_dele...
File ash/common/palette_delegate.h (right):

https://codereview.chromium.org/2199993002/diff/60001/ash/common/palette_dele...
ash/common/palette_delegate.h:18: 
maybe add a "TODO(jdufault): Add methods: http://crbug.com/[whatever]" here so
people don't get confused about why this is empty? :-)

https://codereview.chromium.org/2199993002/diff/60001/ash/common/shell_delega...
File ash/common/shell_delegate.h (right):

https://codereview.chromium.org/2199993002/diff/60001/ash/common/shell_delega...
ash/common/shell_delegate.h:127: // Creates a palette delegate. Shell takes
ownership of the delegate.
nit: remove comment; both what's returned and the ownership transfer seem
self-documenting

[jdufault, 2016-08-05 17:54:16]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:54:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:35:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:35:45]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-08-05 19:03:37]

https://codereview.chromium.org/2199993002/diff/60001/ash/common/palette_dele...
File ash/common/palette_delegate.h (right):

https://codereview.chromium.org/2199993002/diff/60001/ash/common/palette_dele...
ash/common/palette_delegate.h:18: 
On 2016/08/05 15:48:52, Daniel Erat wrote:
> maybe add a "TODO(jdufault): Add methods: http://crbug.com/[whatever]%22 here
so
> people don't get confused about why this is empty? :-)

Done.

https://codereview.chromium.org/2199993002/diff/60001/ash/common/shell_delega...
File ash/common/shell_delegate.h (right):

https://codereview.chromium.org/2199993002/diff/60001/ash/common/shell_delega...
ash/common/shell_delegate.h:127: // Creates a palette delegate. Shell takes
ownership of the delegate.
On 2016/08/05 15:48:52, Daniel Erat wrote:
> nit: remove comment; both what's returned and the ownership transfer seem
> self-documenting

Done.

[jdufault, 2016-08-05 19:04:04]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-08-05 19:04:04]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2199993002/#ps80001
(title: "Nits")

[commit-bot: I haz the power, 2016-08-05 19:04:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 19:14:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-05 19:16:30]

Description was changed from

==========
Add generic PaletteDelegate code.

The delegate methods will be populated in later CLs as needed. This CL just
provides the delegate structure.

BUG=616112
==========

to

==========
Add generic PaletteDelegate code.

The delegate methods will be populated in later CLs as needed. This CL just
provides the delegate structure.

BUG=616112

Committed: https://crrev.com/0f4fa6ef10afabc0f4b889a3175b4aa0c8d715cf
Cr-Commit-Position: refs/heads/master@{#410132}
==========

[commit-bot: I haz the power, 2016-08-05 19:16:32]

Patchset 5 (id:??) landed as
https://crrev.com/0f4fa6ef10afabc0f4b889a3175b4aa0c8d715cf
Cr-Commit-Position: refs/heads/master@{#410132}