Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2216933003: Implement the palette help and options buttons. (Closed)

Created:
4 years, 4 months ago by jdufault
Modified:
4 years, 4 months ago
Reviewers:
oshima, Steven Holte
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@palette-delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement the palette help and options buttons. BUG=625251 Committed: https://crrev.com/2c49f1d783a00f8a7dcb31b36d845f150ffb5d80 Cr-Commit-Position: refs/heads/master@{#411856}

Patch Set 1 : Initial upload #

Total comments: 2

Patch Set 2 : Address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -57 lines) Patch
M ash/common/system/chromeos/palette/palette_tray.h View 2 chunks +3 lines, -1 line 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 1 4 chunks +58 lines, -46 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_popup_header_button.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_popup_header_button.cc View 2 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 28 (18 generated)
jdufault
Oshima, PTAL. Thanks!
4 years, 4 months ago (2016-08-08 20:40:55 UTC) #12
oshima
lgtm with a nit https://codereview.chromium.org/2216933003/diff/20001/ash/common/system/chromeos/palette/palette_tray.cc File ash/common/system/chromeos/palette/palette_tray.cc (right): https://codereview.chromium.org/2216933003/diff/20001/ash/common/system/chromeos/palette/palette_tray.cc#newcode60 ash/common/system/chromeos/palette/palette_tray.cc:60: TitleView(PaletteTray* palette_tray) : palette_tray_(palette_tray) { ...
4 years, 4 months ago (2016-08-10 20:22:44 UTC) #13
jdufault
Thanks! https://codereview.chromium.org/2216933003/diff/20001/ash/common/system/chromeos/palette/palette_tray.cc File ash/common/system/chromeos/palette/palette_tray.cc (right): https://codereview.chromium.org/2216933003/diff/20001/ash/common/system/chromeos/palette/palette_tray.cc#newcode60 ash/common/system/chromeos/palette/palette_tray.cc:60: TitleView(PaletteTray* palette_tray) : palette_tray_(palette_tray) { On 2016/08/10 20:22:44, ...
4 years, 4 months ago (2016-08-11 18:55:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216933003/40001
4 years, 4 months ago (2016-08-11 18:56:09 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/236223)
4 years, 4 months ago (2016-08-11 19:07:05 UTC) #19
jdufault
holte@ PTAL at tools/metrics/actions/actions.xml. Thanks!
4 years, 4 months ago (2016-08-11 19:40:20 UTC) #21
Steven Holte
On 2016/08/11 19:40:20, jdufault wrote: > holte@ PTAL at tools/metrics/actions/actions.xml. Thanks! actions lgtm
4 years, 4 months ago (2016-08-13 00:39:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216933003/40001
4 years, 4 months ago (2016-08-13 00:40:32 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-13 02:13:21 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 02:15:32 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c49f1d783a00f8a7dcb31b36d845f150ffb5d80
Cr-Commit-Position: refs/heads/master@{#411856}

Powered by Google App Engine
This is Rietveld 408576698