Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2199833002: Unbreak two iOS bots after gn switch. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, hans
CC:
chromium-reviews, smut
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ios/build/bots/chromium.fyi/ClangToTiOS.json View 1 chunk +1 line, -1 line 0 comments Download
M ios/build/bots/chromium.fyi/EarlGreyiOS.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Nico
4 years, 4 months ago (2016-08-01 17:31:18 UTC) #4
Dirk Pranke
I thought I fixed this already ... hmm ...
4 years, 4 months ago (2016-08-01 17:41:56 UTC) #6
Dirk Pranke
bah, yeah, I only got one out of the three, sorry! lgtm.
4 years, 4 months ago (2016-08-01 17:42:47 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c5dd0a9e71113c3840ac682be91af500a7891dfd Cr-Commit-Position: refs/heads/master@{#409001}
4 years, 4 months ago (2016-08-01 18:27:29 UTC) #11
Nico
Committed patchset #1 (id:1) manually as c5dd0a9e71113c3840ac682be91af500a7891dfd (presubmit successful).
4 years, 4 months ago (2016-08-01 18:31:48 UTC) #13
hans
4 years, 4 months ago (2016-08-01 20:26:52 UTC) #15
Message was sent while issue was closed.
Thanks! Just started looking at this. Always nice when things turn out already
fixed :-)

Powered by Google App Engine
This is Rietveld 408576698