Clarify fullscreenElement vs. currentFullScreenElement distinction

Clarify fullscreenElement vs. currentFullScreenElement distinction

No observable changes are intended.

This may make DocumentFullscreen::fullscreenElement and
::currentFullScreenElement slightly slower, but if that turns out to be
a problem a reasonable fix would be to inline the corresponding getters
in Fullscreen.h.

The Screen in m_fullScreenElementStack is lowercased, as it should be
and it shows all the places where it is used internally.

BUG=402421
R=eae@chromium.org

Committed: https://crrev.com/63ec834253d3a3da461f96ec5f659b524bf8ad58
Cr-Commit-Position: refs/heads/master@{#408993}

[foolip, 2016-08-01 14:29:51]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 14:30:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 15:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 15:34:37]

Dry run: This issue passed the CQ dry run.

[eae, 2016-08-01 16:13:39]

Can we try to be consistent about capitalization for at least the internal API?
Having both fullScreen and fullscreen is confusing.

[foolip, 2016-08-01 16:37:48]

On 2016/08/01 16:13:39, eae wrote:
> Can we try to be consistent about capitalization for at least the internal
API?
> Having both fullScreen and fullscreen is confusing.

I changed just the fullscreen element stack one because that one is newer and
will remain, but left the things that will go away either in the next step of
issue 402421 or when relanding top layer. But I do a repo-wide
s/ullScreen/ullscreen/ before this CL if you like, it is something I plan to do
at some point anyway.

[foolip, 2016-08-01 16:40:07]

On 2016/08/01 16:37:48, foolip wrote:
> On 2016/08/01 16:13:39, eae wrote:
> > Can we try to be consistent about capitalization for at least the internal
> API?
> > Having both fullScreen and fullscreen is confusing.
> 
> I changed just the fullscreen element stack one because that one is newer and
> will remain, but left the things that will go away either in the next step of
> issue 402421 or when relanding top layer. But I do a repo-wide
> s/ullScreen/ullscreen/ before this CL if you like, it is something I plan to
do
> at some point anyway.

+could

[eae, 2016-08-01 16:41:13]

Nah, this is OK as long as the end goal is to fix it all :)

LGTM

[foolip, 2016-08-01 17:25:56]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-08-01 17:26:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 17:30:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-01 17:33:35]

Description was changed from

==========
Clarify fullscreenElement vs. currentFullScreenElement distinction

No observable changes are intended.

This may make DocumentFullscreen::fullscreenElement and
::currentFullScreenElement slightly slower, but if that turns out to be
a problem a reasonable fix would be to inline the corresponding getters
in Fullscreen.h.

The Screen in m_fullScreenElementStack is lowercased, as it should be
and it shows all the places where it is used internally.

BUG=402421
R=eae@chromium.org
==========

to

==========
Clarify fullscreenElement vs. currentFullScreenElement distinction

No observable changes are intended.

This may make DocumentFullscreen::fullscreenElement and
::currentFullScreenElement slightly slower, but if that turns out to be
a problem a reasonable fix would be to inline the corresponding getters
in Fullscreen.h.

The Screen in m_fullScreenElementStack is lowercased, as it should be
and it shows all the places where it is used internally.

BUG=402421
R=eae@chromium.org

Committed: https://crrev.com/63ec834253d3a3da461f96ec5f659b524bf8ad58
Cr-Commit-Position: refs/heads/master@{#408993}
==========

[commit-bot: I haz the power, 2016-08-01 17:33:36]

Patchset 1 (id:??) landed as
https://crrev.com/63ec834253d3a3da461f96ec5f659b524bf8ad58
Cr-Commit-Position: refs/heads/master@{#408993}