third_party/WebKit/Source/core/css/SelectorChecker.cpp - Issue 2199783002: Clarify fullscreenElement vs. currentFullScreenElement distinction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/SelectorChecker.cpp

Issue 2199783002: Clarify fullscreenElement vs. currentFullScreenElement distinction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/SelectorChecker.cpp

diff --git a/third_party/WebKit/Source/core/css/SelectorChecker.cpp b/third_party/WebKit/Source/core/css/SelectorChecker.cpp

index 699c10bb79fdae0a85c62bf2eaf20b8d0a8a5d09..d8773a59d9a38784c8b699f1167e022b1a3bf647 100644

--- a/third_party/WebKit/Source/core/css/SelectorChecker.cpp

+++ b/third_party/WebKit/Source/core/css/SelectorChecker.cpp

@@ -877,7 +877,7 @@ bool SelectorChecker::checkPseudoClass(const SelectorCheckingContext& context, M

// context's Document is in the fullscreen state has the 'full-screen' pseudoclass applied.

if (isHTMLFrameElementBase(element) && element.containsFullScreenElement())

return true;

- return Fullscreen::isActiveFullScreenElement(element);

+ return Fullscreen::isCurrentFullScreenElement(element);

case CSSSelector::PseudoFullScreenAncestor:

return element.containsFullScreenElement();

case CSSSelector::PseudoInRange:

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DocumentFullscreen.h » ('j') | no next file with comments »