MD Settings: Minor refactor of settings-animated-pages

MD Settings: Minor refactor of settings-animated-pages

Uses the shiny new routing functions. Splits currentRouteChanged into a helper
function for going to a subpage versus going back to the main page.

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d868b5c2353b312408e33700f3f027aa3912a5ab
Cr-Commit-Position: refs/heads/master@{#409110}

[michaelpg, 2016-08-01 08:33:18]

Description was changed from

==========
MD Settings: Minor refactor of settings-animated-pages

Uses the shiny new routing functions. Splits currentRouteChanged into a helper
function for going to a subpage versus going back to the main page.

R=tommycli@chromium.org
BUG=none
==========

to

==========
MD Settings: Minor refactor of settings-animated-pages

Uses the shiny new routing functions. Splits currentRouteChanged into a helper
function for going to a subpage versus going back to the main page.

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-01 08:37:14]

PTAL.

https://codereview.chromium.org/2199723002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_animated_pages.js
(right):

https://codereview.chromium.org/2199723002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_animated_pages.js:81:
if (newRoute.section == this.section && newRoute.subpage.length > 0) {
this saves some work, since all <settings-animated-pages> on the page run this
whenever the route changes. most of them will fail this and just set |selected|
to 'main' (which is almost always a no-op)

[tommycli, 2016-08-01 16:25:36]

lgtm

[michaelpg, 2016-08-01 17:56:24]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-01 17:56:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2199723002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-01 17:56:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 17:56:56]

This CL has an open dependency (Issue 2197093002 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[michaelpg, 2016-08-02 00:09:15]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-08-02 00:09:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 01:14:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 01:16:23]

Description was changed from

==========
MD Settings: Minor refactor of settings-animated-pages

Uses the shiny new routing functions. Splits currentRouteChanged into a helper
function for going to a subpage versus going back to the main page.

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Minor refactor of settings-animated-pages

Uses the shiny new routing functions. Splits currentRouteChanged into a helper
function for going to a subpage versus going back to the main page.

R=tommycli@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d868b5c2353b312408e33700f3f027aa3912a5ab
Cr-Commit-Position: refs/heads/master@{#409110}
==========

[commit-bot: I haz the power, 2016-08-02 01:16:24]

Patchset 2 (id:??) landed as
https://crrev.com/d868b5c2353b312408e33700f3f027aa3912a5ab
Cr-Commit-Position: refs/heads/master@{#409110}