Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2199723002: MD Settings: Minor refactor of settings-animated-pages (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@FixSubpageExpandStartHeight
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Minor refactor of settings-animated-pages Uses the shiny new routing functions. Splits currentRouteChanged into a helper function for going to a subpage versus going back to the main page. R=tommycli@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d868b5c2353b312408e33700f3f027aa3912a5ab Cr-Commit-Position: refs/heads/master@{#409110}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M chrome/browser/resources/settings/settings_page/settings_animated_pages.js View 1 2 chunks +39 lines, -30 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
michaelpg
PTAL. https://codereview.chromium.org/2199723002/diff/1/chrome/browser/resources/settings/settings_page/settings_animated_pages.js File chrome/browser/resources/settings/settings_page/settings_animated_pages.js (right): https://codereview.chromium.org/2199723002/diff/1/chrome/browser/resources/settings/settings_page/settings_animated_pages.js#newcode81 chrome/browser/resources/settings/settings_page/settings_animated_pages.js:81: if (newRoute.section == this.section && newRoute.subpage.length > 0) ...
4 years, 4 months ago (2016-08-01 08:37:14 UTC) #2
tommycli
lgtm
4 years, 4 months ago (2016-08-01 16:25:36 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2197093002 Patch 40001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-01 17:56:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199723002/20001
4 years, 4 months ago (2016-08-02 00:09:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 01:14:28 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 01:16:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d868b5c2353b312408e33700f3f027aa3912a5ab
Cr-Commit-Position: refs/heads/master@{#409110}

Powered by Google App Engine
This is Rietveld 408576698