MD Settings: Fix starting height of expanding sections

MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding asynchronicity...
but that's just adding fuel to the fire. Subpages opening/closing will be done
by events soon, so we can fire an event here eventually.

R=tommycli@chromium.org
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ded0cc6677d07279b6722bd73ed0f32723d90283
Cr-Commit-Position: refs/heads/master@{#409014}

[michaelpg, 2016-08-01 08:25:28]

Description was changed from

==========
MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding
asynchronicity...
but that's just adding fuel to the fire.

R=tommycli@chromium.org
BUG=633046
==========

to

==========
MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding
asynchronicity...
but that's just adding fuel to the fire.

R=tommycli@chromium.org
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-01 15:31:34]

Description was changed from

==========
MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding
asynchronicity...
but that's just adding fuel to the fire.

R=tommycli@chromium.org
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding
asynchronicity...
but that's just adding fuel to the fire. Subpages opening/closing will be done
by events soon, so we can fire an event here eventually.

R=tommycli@chromium.org
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-01 16:20:28]

On 2016/08/01 08:34:42, michaelpg wrote:

So in the old world, route changes propagated upwards from the navigating
element, to settings-router, and then back down to all the elements that weren't
affected yet.

Right now, route changes always propagate downwards from settings-router.

But in the next CL, once RouteObserverBehavior lands, route changes will hit
elements in an undefined order. The main page could be hit first, OR the
settings-animated-pages would be hit.

Is this CL resilient to an undefined order of route change notifications?

[michaelpg, 2016-08-01 16:23:41]

On 2016/08/01 16:20:28, tommycli wrote:
> On 2016/08/01 08:34:42, michaelpg wrote:
> 
> So in the old world, route changes propagated upwards from the navigating
> element, to settings-router, and then back down to all the elements that
weren't
> affected yet.
> 
> Right now, route changes always propagate downwards from settings-router.
> 
> But in the next CL, once RouteObserverBehavior lands, route changes will hit
> elements in an undefined order. The main page could be hit first, OR the
> settings-animated-pages would be hit.
> 
> Is this CL resilient to an undefined order of route change notifications?

well... it's *more* resilient. i'm sure there are still issues.

I don't think this would cause a regression regardless of the ordering.
If the expand animation starts first and fixes the height, setting the
height of the settings-animated-pages shouldn't do anything.

[tommycli, 2016-08-01 16:24:19]

lgtm thanks for the info!

[michaelpg, 2016-08-01 17:55:08]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-01 17:55:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2197093002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-01 17:55:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 19:14:23]

Description was changed from

==========
MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding
asynchronicity...
but that's just adding fuel to the fire. Subpages opening/closing will be done
by events soon, so we can fire an event here eventually.

R=tommycli@chromium.org
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding
asynchronicity...
but that's just adding fuel to the fire. Subpages opening/closing will be done
by events soon, so we can fire an event here eventually.

R=tommycli@chromium.org
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-01 19:14:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-01 19:16:17]

Description was changed from

==========
MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding
asynchronicity...
but that's just adding fuel to the fire. Subpages opening/closing will be done
by events soon, so we can fire an event here eventually.

R=tommycli@chromium.org
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix starting height of expanding sections

Changes to the way the route is set have shuffled how currentRoute changes
propagate, making callbacks run at different times than before.

One result is that the settings-animated-pages selects its subpage before the
MainPageBehavior gets a chance to freeze the section's height. The fix, albeit
a bit hacky, is to freeze the height of settings-animated-pages before selecting
a subpage from the main page.

I also considered ways of changing the order of callbacks or adding
asynchronicity...
but that's just adding fuel to the fire. Subpages opening/closing will be done
by events soon, so we can fire an event here eventually.

R=tommycli@chromium.org
BUG=633046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ded0cc6677d07279b6722bd73ed0f32723d90283
Cr-Commit-Position: refs/heads/master@{#409014}
==========

[commit-bot: I haz the power, 2016-08-01 19:16:18]

Patchset 3 (id:??) landed as
https://crrev.com/ded0cc6677d07279b6722bd73ed0f32723d90283
Cr-Commit-Position: refs/heads/master@{#409014}