Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2199653002: Revert of Use MediaRecorder to capture video for quality test. (Closed)

Created:
4 years, 4 months ago by kjellander_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, tnakamura+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use MediaRecorder to capture video for quality test. (patchset #1 id:1 of https://codereview.chromium.org/2183873002/ ) Reason for revert: Performance numbers regressed a bit too much after landing this, example: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxozpqQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICght-9qAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxuK2sgkM Original issue's description: > Use MediaRecorder to capture video for quality test. > > Retrite the WebRTC video quality test to use the MediaRecorder API > instead of recording from a canvas. > > BUG=631458 > > Committed: https://crrev.com/0204f3d64d8472a25d93312356d2a1c4acbb600e > Cr-Commit-Position: refs/heads/master@{#408633} TBR=phoglund@chromium.org,mcasas@chromium.org,ehmaldonado@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=631458 Committed: https://crrev.com/668a1e44390e683f82f24a5318946bf0889cffe1 Cr-Commit-Position: refs/heads/master@{#408919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -85 lines) Patch
M chrome/browser/media/webrtc_video_quality_browsertest.cc View 4 chunks +66 lines, -35 lines 0 comments Download
M chrome/test/data/webrtc/video_extraction.js View 3 chunks +163 lines, -49 lines 0 comments Download
M chrome/test/data/webrtc/webrtc_video_quality_test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_chromium
Created Revert of Use MediaRecorder to capture video for quality test.
4 years, 4 months ago (2016-08-01 05:54:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2199653002/1
4 years, 4 months ago (2016-08-01 05:54:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 06:49:58 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/668a1e44390e683f82f24a5318946bf0889cffe1 Cr-Commit-Position: refs/heads/master@{#408919}
4 years, 4 months ago (2016-08-01 06:51:54 UTC) #7
ehmaldonado_chromium
4 years, 4 months ago (2016-08-02 16:01:28 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2199373002/ by ehmaldonado@chromium.org.

The reason for reverting is: I now tell ffmpeg the desired resolution for the
output file.

.

Powered by Google App Engine
This is Rietveld 408576698