third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2199523002: Convert WebRange to be a simple pair of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2199523002: Convert WebRange to be a simple pair of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot the exports. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index a881cd8ec2ae8b71dc132bd296ab5bd937ac4212..d773da8070b2b47fbbd7fdedbaac6060d8fdbf44 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -5151,7 +5151,7 @@ TEST_P(ParameterizedWebFrameTest, ReplaceMisspelledRange)

const int allTextBeginOffset = 0;

const int allTextLength = 11;

- frame->selectRange(WebRange::fromDocumentRange(frame, allTextBeginOffset, allTextLength));

+ frame->selectRange(WebRange(allTextBeginOffset, allTextLength));

EphemeralRange selectionRange = frame->frame()->selection().selection().toNormalizedEphemeralRange();

EXPECT_EQ(1, spellcheck.numberOfTimesChecked());

@@ -5185,7 +5185,7 @@ TEST_P(ParameterizedWebFrameTest, RemoveSpellingMarkers)

const int allTextBeginOffset = 0;

const int allTextLength = 11;

- frame->selectRange(WebRange::fromDocumentRange(frame, allTextBeginOffset, allTextLength));

+ frame->selectRange(WebRange(allTextBeginOffset, allTextLength));

EphemeralRange selectionRange = frame->frame()->selection().selection().toNormalizedEphemeralRange();

EXPECT_EQ(0U, document->markers().markersInRange(selectionRange, DocumentMarker::Spelling).size());