third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2199523002: Convert WebRange to be a simple pair of numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2199523002: Convert WebRange to be a simple pair of numbers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot the exports. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 271807746f22e34e871e1ab137be4e0e14724c52..89f309ee11bd8c8c74fe990ccdcb4cc1ccb6ffde 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -2851,11 +2851,8 @@ bool WebViewImpl::getCompositionCharacterBounds(WebVector<WebRect>& bounds)

void WebViewImpl::applyReplacementRange(int start, int length)

{

- if (WebLocalFrame* frame = focusedFrame()) {

- WebRange webrange = WebRange::fromDocumentRange(frame, start, length);

- if (!webrange.isNull())

- frame->selectRange(webrange);

- }

+ if (WebLocalFrame* frame = focusedFrame())

+ frame->selectRange(WebRange(start, length));

}

// WebView --------------------------------------------------------------------