Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2199453002: Attempt to print the stack using the profiler upon assertion failure. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Attempt to print the stack using the profiler upon assertion failure. Fix mismatched free of native symbol. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b01541d54d72ddc02bf74305a36c099056632215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/platform/assert.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-07-29 20:19:34 UTC) #2
Cutch
LGTM
4 years, 4 months ago (2016-07-29 20:22:22 UTC) #3
rmacnak
4 years, 4 months ago (2016-07-29 20:29:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b01541d54d72ddc02bf74305a36c099056632215 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698