runtime/vm/profiler.cc - Issue 2199453002: Attempt to print the stack using the profiler upon assertion failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler.cc

Issue 2199453002: Attempt to print the stack using the profiler upon assertion failure. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/profiler.cc

diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc

index 6e3527aeaeef95644e728b63e91e8aa81ab364c1..165822ef6480a2e91bb7daaa8aecd8749b92aca8 100644

--- a/runtime/vm/profiler.cc

+++ b/runtime/vm/profiler.cc

@@ -340,7 +340,7 @@ static void DumpStackFrame(intptr_t frame_index, uword pc) {

} else {

OS::Print("Frame[%" Pd "] = `%s` [0x%" Px "]\n",

frame_index, native_symbol_name, pc);

- free(native_symbol_name);

+ NativeSymbolResolver::FreeSymbolName(native_symbol_name);

}

« no previous file with comments | « runtime/platform/assert.cc ('k') | no next file » | no next file with comments »