Mechanical change in the component updater Configurator.

Mechanical change in the component updater Configurator.

This is the first CL in a series of CLs to implement component updater
group policies

The CL renames a few functions in the Configurator, for consistency.
It introduces Configurator::EnabledComponentUpdates and
CrxComponent::supports_group_policy_enable_component_updates.

These members are placeholders and have no effect on the current
code behavior.

BUG=624128
Committed: https://crrev.com/cb4e5e933ae9975ccc24e83f48369716d65b669d
Cr-Commit-Position: refs/heads/master@{#409337}

[Sorin Jianu, 2016-08-02 18:37:04]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:37:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2016-08-02 18:45:17]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:45:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 18:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 18:56:29]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Sorin Jianu, 2016-08-02 19:41:31]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 19:42:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2016-08-02 19:43:11]

Description was changed from

==========
Mechanical change in the component updater Configurator.

This is the first CL in a series of CLs to implement component updater
group policies

The CL renames a few functions in the Configurator, for consistency.
It introduces Configurator::EnabledComponentUpdates and
CrxComponent::supports_group_policy_enable_component_updates.

These members are placeholders and have no effect on the current
code behavior.

BUG=624128
==========

to

==========
Mechanical change in the component updater Configurator.

This is the first CL in a series of CLs to implement component updater
group policies

The CL renames a few functions in the Configurator, for consistency.
It introduces Configurator::EnabledComponentUpdates and
CrxComponent::supports_group_policy_enable_component_updates.

These members are placeholders and have no effect on the current
code behavior.

BUG=624128
==========

[Sorin Jianu, 2016-08-02 19:43:11]

sorin@chromium.org changed reviewers:
+ asargent@chromium.org, rohitrao@chromium.org, waffles@chromium.org

[Sorin Jianu, 2016-08-02 20:09:23]

Antony, please I need an owners approval for the paths under extensions/.

Rohit, I need owner's approval please for the iOS paths.

[rohitrao (ping after 24h), 2016-08-02 20:17:37]

https://codereview.chromium.org/2199423002/diff/40001/ios/chrome/browser/comp...
File ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
(right):

https://codereview.chromium.org/2199423002/diff/40001/ios/chrome/browser/comp...
ios/chrome/browser/component_updater/ios_component_updater_configurator.cc:142:
return configurator_impl_.EnabledBackgroundDownloader();
Should this be calling configurator_impl_.EnabledComponentUpdates()?

[Sorin Jianu, 2016-08-02 20:24:38]

Thank you Rohit. PTAL.

https://codereview.chromium.org/2199423002/diff/40001/ios/chrome/browser/comp...
File ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
(right):

https://codereview.chromium.org/2199423002/diff/40001/ios/chrome/browser/comp...
ios/chrome/browser/component_updater/ios_component_updater_configurator.cc:142:
return configurator_impl_.EnabledBackgroundDownloader();
On 2016/08/02 20:17:37, rohitrao wrote:
> Should this be calling configurator_impl_.EnabledComponentUpdates()?

Yes. Thank you!

[rohitrao (ping after 24h), 2016-08-02 20:30:11]

ios lgtm

[waffles, 2016-08-02 20:35:56]

lgtm

[asargent_no_longer_on_chrome, 2016-08-02 20:44:09]

extensions lgtm

[Sorin Jianu, 2016-08-02 20:52:16]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2016-08-02 20:52:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 21:48:57]

Description was changed from

==========
Mechanical change in the component updater Configurator.

This is the first CL in a series of CLs to implement component updater
group policies

The CL renames a few functions in the Configurator, for consistency.
It introduces Configurator::EnabledComponentUpdates and
CrxComponent::supports_group_policy_enable_component_updates.

These members are placeholders and have no effect on the current
code behavior.

BUG=624128
==========

to

==========
Mechanical change in the component updater Configurator.

This is the first CL in a series of CLs to implement component updater
group policies

The CL renames a few functions in the Configurator, for consistency.
It introduces Configurator::EnabledComponentUpdates and
CrxComponent::supports_group_policy_enable_component_updates.

These members are placeholders and have no effect on the current
code behavior.

BUG=624128
==========

[commit-bot: I haz the power, 2016-08-02 21:48:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-02 21:52:38]

Description was changed from

==========
Mechanical change in the component updater Configurator.

This is the first CL in a series of CLs to implement component updater
group policies

The CL renames a few functions in the Configurator, for consistency.
It introduces Configurator::EnabledComponentUpdates and
CrxComponent::supports_group_policy_enable_component_updates.

These members are placeholders and have no effect on the current
code behavior.

BUG=624128
==========

to

==========
Mechanical change in the component updater Configurator.

This is the first CL in a series of CLs to implement component updater
group policies

The CL renames a few functions in the Configurator, for consistency.
It introduces Configurator::EnabledComponentUpdates and
CrxComponent::supports_group_policy_enable_component_updates.

These members are placeholders and have no effect on the current
code behavior.

BUG=624128

Committed: https://crrev.com/cb4e5e933ae9975ccc24e83f48369716d65b669d
Cr-Commit-Position: refs/heads/master@{#409337}
==========

[commit-bot: I haz the power, 2016-08-02 21:52:39]

Patchset 4 (id:??) landed as
https://crrev.com/cb4e5e933ae9975ccc24e83f48369716d65b669d
Cr-Commit-Position: refs/heads/master@{#409337}