Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2199403002: Converted general-error tag (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added missing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -42 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +2 lines, -12 lines 0 comments Download
M runtime/observatory/lib/src/elements/general_error.dart View 1 1 chunk +67 lines, -7 lines 0 comments Download
D runtime/observatory/lib/src/elements/general_error.html View 1 chunk +0 lines, -18 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/general_error/element_test.dart View 1 chunk +61 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/general_error/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-02 18:19:45 UTC) #2
Cutch
lgtm https://codereview.chromium.org/2199403002/diff/1/runtime/observatory/lib/src/elements/general_error.dart File runtime/observatory/lib/src/elements/general_error.dart (right): https://codereview.chromium.org/2199403002/diff/1/runtime/observatory/lib/src/elements/general_error.dart#newcode16 runtime/observatory/lib/src/elements/general_error.dart:16: class GeneralErrorElement extends HtmlElement implements Renderable{ space before ...
4 years, 4 months ago (2016-08-02 23:58:29 UTC) #3
cbernaschina
https://codereview.chromium.org/2199403002/diff/1/runtime/observatory/lib/src/elements/general_error.dart File runtime/observatory/lib/src/elements/general_error.dart (right): https://codereview.chromium.org/2199403002/diff/1/runtime/observatory/lib/src/elements/general_error.dart#newcode16 runtime/observatory/lib/src/elements/general_error.dart:16: class GeneralErrorElement extends HtmlElement implements Renderable{ On 2016/08/02 23:58:28, ...
4 years, 4 months ago (2016-08-03 22:00:37 UTC) #4
cbernaschina
4 years, 4 months ago (2016-08-04 01:16:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c9b1215870385b4c77accc535aed309afbb0f0ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698