Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2199403002: Converted general-error tag (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Added missing space Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/elements.html ('k') | runtime/observatory/lib/src/elements/general_error.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 0129c3483241971b0cf60005fb511c885deb1f34..365e227818c0e558cdc633ccb0129b7608ed82a7 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -84,7 +84,7 @@ class ErrorPage extends Page {
void onInstall() {
if (element == null) {
// Lazily create page.
- element = new Element.tag('general-error');
+ element = new GeneralErrorElement(app.notifications, queue: app.queue);
}
}
@@ -92,17 +92,7 @@ class ErrorPage extends Page {
assert(element != null);
assert(canVisit(uri));
- /*
- if (uri.path == '') {
- // Nothing requested.
- return;
- }
- */
-
- if (element != null) {
- GeneralErrorElement serviceElement = element;
- serviceElement.message = "Path '${uri.path}' not found";
- }
+ (element as GeneralErrorElement).message = "Path '${uri.path}' not found";
}
/// Catch all.
« no previous file with comments | « runtime/observatory/lib/elements.html ('k') | runtime/observatory/lib/src/elements/general_error.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698