Remove deprecated priority-less SequencedWorkerPool constructor.

Remove deprecated priority-less SequencedWorkerPool constructor.

And migrate one callsite missed in https://codereview.chromium.org/2077413009:
 - arc_process_service.cc

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org

Committed: https://crrev.com/baf03c214ffd661fd81c0e5e374f7e659d74873f
Cr-Commit-Position: refs/heads/master@{#411905}

[gab, 2016-08-03 18:31:44]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2016-08-03 18:31:45]

TBR danakj: this is essentially the revert of PS 10->11 on
https://codereview.chromium.org/2077413009/ (you had lgtm'ed PS 10 but I had to
put back this constructor temporarily -- removing it again now)

[gab, 2016-08-03 18:31:56]

Description was changed from

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
==========

to

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org
==========

[gab, 2016-08-04 22:44:03]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2016-08-04 22:44:20]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-04 22:44:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 23:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 23:17:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2016-08-05 00:25:53]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:26:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-08-05 00:28:38]

Description was changed from

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org
==========

to

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

And migrate few callsites missed in https://codereview.chromium.org/2077413009:
 - arc_process_service.cc

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org
==========

[gab, 2016-08-05 00:30:53]

gab@chromium.org changed reviewers:
+ hidehiko@chromium.org

[gab, 2016-08-05 00:30:53]

@hidehiko: PTAL at arc_process_service.cc changes, refer to
https://codereview.chromium.org/2077413009 for description of appropriate
priorities for this migration and please let me know if ArcProcessService
doesn't need to be USER_BLOCKING, thanks!

[commit-bot: I haz the power, 2016-08-05 01:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 01:22:22]

Dry run: This issue passed the CQ dry run.

[gab, 2016-08-05 01:23:01]

Description was changed from

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

And migrate few callsites missed in https://codereview.chromium.org/2077413009:
 - arc_process_service.cc

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org
==========

to

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

And migrate one callsite missed in https://codereview.chromium.org/2077413009:
 - arc_process_service.cc

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org
==========

[gab, 2016-08-05 01:25:11]

On 2016/08/05 00:30:53, gab wrote:
> @hidehiko: PTAL at arc_process_service.cc changes, refer to
> https://codereview.chromium.org/2077413009 for description of appropriate
> priorities for this migration and please let me know if ArcProcessService
> doesn't need to be USER_BLOCKING, thanks!

Also note that going into the TaskScheduler pool (which is what this eventually
entails) means that, although it will stay single-threaded per having asked for
specifically 1 thread, it might share a thread with other unrelated tasks (of
the same TaskTraits -- in this case WithFileIO() + given priority). Let me know
if this isn't okay.

[hidehiko, 2016-08-09 05:59:36]

LGTM. Thank you for clean up. (Sorry for the delay, as I was OOO in these days).
Commented inline.

https://codereview.chromium.org/2199353002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_process_service.cc (right):

https://codereview.chromium.org/2199353002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_process_service.cc:45:
base::TaskPriority::USER_BLOCKING)),
This is ok for me, or can be USER_VISIBLE, to be consistent with the original
code.
There may be a room to lower the priority in a future CL.

Added cylee@ and nya@ for FYI.

[cylee1, 2016-08-09 08:35:40]

cylee@chromium.org changed reviewers:
+ cylee@chromium.org

[cylee1, 2016-08-09 08:35:41]

lgtm

https://codereview.chromium.org/2199353002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_process_service.cc (right):

https://codereview.chromium.org/2199353002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_process_service.cc:45:
base::TaskPriority::USER_BLOCKING)),
On 2016/08/09 05:59:36, hidehiko wrote:
> This is ok for me, or can be USER_VISIBLE, to be consistent with the original
> code.
> There may be a room to lower the priority in a future CL.
> 
> Added cylee@ and nya@ for FYI.

USER_VISIBLe looks good to me.

BTW there's an ongoing CL which changes SequencedWorkerPool to Thread. 
https://codereview.chromium.org/2025593003/
So this change is also temporarily.

[gab, 2016-08-09 14:24:06]

Done thanks

https://codereview.chromium.org/2199353002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_process_service.cc (right):

https://codereview.chromium.org/2199353002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_process_service.cc:45:
base::TaskPriority::USER_BLOCKING)),
On 2016/08/09 08:35:41, cylee1 wrote:
> On 2016/08/09 05:59:36, hidehiko wrote:
> > This is ok for me, or can be USER_VISIBLE, to be consistent with the
original
> > code.
> > There may be a room to lower the priority in a future CL.
> > 
> > Added cylee@ and nya@ for FYI.
> 
> USER_VISIBLe looks good to me.
> 
> BTW there's an ongoing CL which changes SequencedWorkerPool to Thread. 
> https://codereview.chromium.org/2025593003/
> So this change is also temporarily.

Done.

[danakj, 2016-08-09 21:55:40]

base LGTM

[gab, 2016-08-13 22:44:38]

The CQ bit was checked by gab@chromium.org

[gab, 2016-08-13 22:44:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, cylee@chromium.org
Link to the patchset: https://codereview.chromium.org/2199353002/#ps60001
(title: "ArcProcessService => USER_VISIBLE")

[commit-bot: I haz the power, 2016-08-13 22:44:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-14 01:40:28]

Description was changed from

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

And migrate one callsite missed in https://codereview.chromium.org/2077413009:
 - arc_process_service.cc

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org
==========

to

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

And migrate one callsite missed in https://codereview.chromium.org/2077413009:
 - arc_process_service.cc

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org
==========

[commit-bot: I haz the power, 2016-08-14 01:40:29]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-14 01:43:10]

Description was changed from

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

And migrate one callsite missed in https://codereview.chromium.org/2077413009:
 - arc_process_service.cc

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org
==========

to

==========
Remove deprecated priority-less SequencedWorkerPool constructor.

And migrate one callsite missed in https://codereview.chromium.org/2077413009:
 - arc_process_service.cc

After last two callers are removed:
 - https://codereview.chromium.org/2103883004
 - https://codereview.chromium.org/2197753002/

BUG=622400
TBR=danakj@chromium.org

Committed: https://crrev.com/baf03c214ffd661fd81c0e5e374f7e659d74873f
Cr-Commit-Position: refs/heads/master@{#411905}
==========

[commit-bot: I haz the power, 2016-08-14 01:43:11]

Patchset 3 (id:??) landed as
https://crrev.com/baf03c214ffd661fd81c0e5e374f7e659d74873f
Cr-Commit-Position: refs/heads/master@{#411905}