Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: base/threading/sequenced_worker_pool.h

Issue 2199353002: Remove deprecated priority-less SequencedWorkerPool constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b3_mix
Patch Set: ArcProcessService => USER_VISIBLE Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/threading/sequenced_worker_pool.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_THREADING_SEQUENCED_WORKER_POOL_H_ 5 #ifndef BASE_THREADING_SEQUENCED_WORKER_POOL_H_
6 #define BASE_THREADING_SEQUENCED_WORKER_POOL_H_ 6 #define BASE_THREADING_SEQUENCED_WORKER_POOL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <cstddef> 10 #include <cstddef>
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 178
179 // Pass the maximum number of threads (they will be lazily created as needed) 179 // Pass the maximum number of threads (they will be lazily created as needed)
180 // and a prefix for the thread name to aid in debugging. |task_priority| will 180 // and a prefix for the thread name to aid in debugging. |task_priority| will
181 // be used to hint base::TaskScheduler for an experiment in which all 181 // be used to hint base::TaskScheduler for an experiment in which all
182 // SequencedWorkerPool tasks will be redirected to it in processes where a 182 // SequencedWorkerPool tasks will be redirected to it in processes where a
183 // base::TaskScheduler was instantiated. 183 // base::TaskScheduler was instantiated.
184 SequencedWorkerPool(size_t max_threads, 184 SequencedWorkerPool(size_t max_threads,
185 const std::string& thread_name_prefix, 185 const std::string& thread_name_prefix,
186 base::TaskPriority task_priority); 186 base::TaskPriority task_priority);
187 187
188 // Deprecated, use the above constructor with |task_priority| instead.
189 // TODO(gab): Cleanup last few use cases of this before running the
190 // aforementioned base::TaskScheduler experiment (or make sure this
191 // constructor results in callers being opted out of the experiment).
192 SequencedWorkerPool(size_t max_threads,
193 const std::string& thread_name_prefix);
194
195 // Like above, but with |observer| for testing. Does not take ownership of 188 // Like above, but with |observer| for testing. Does not take ownership of
196 // |observer|. 189 // |observer|.
197 SequencedWorkerPool(size_t max_threads, 190 SequencedWorkerPool(size_t max_threads,
198 const std::string& thread_name_prefix, 191 const std::string& thread_name_prefix,
199 base::TaskPriority task_priority, 192 base::TaskPriority task_priority,
200 TestingObserver* observer); 193 TestingObserver* observer);
201 194
202 // Returns the sequence token associated with the given name. Calling this 195 // Returns the sequence token associated with the given name. Calling this
203 // function multiple times with the same string will always produce the 196 // function multiple times with the same string will always produce the
204 // same sequence token. If the name has not been used before, a new token 197 // same sequence token. If the name has not been used before, a new token
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 // Avoid pulling in too many headers by putting (almost) everything 367 // Avoid pulling in too many headers by putting (almost) everything
375 // into |inner_|. 368 // into |inner_|.
376 const std::unique_ptr<Inner> inner_; 369 const std::unique_ptr<Inner> inner_;
377 370
378 DISALLOW_COPY_AND_ASSIGN(SequencedWorkerPool); 371 DISALLOW_COPY_AND_ASSIGN(SequencedWorkerPool);
379 }; 372 };
380 373
381 } // namespace base 374 } // namespace base
382 375
383 #endif // BASE_THREADING_SEQUENCED_WORKER_POOL_H_ 376 #endif // BASE_THREADING_SEQUENCED_WORKER_POOL_H_
OLDNEW
« no previous file with comments | « no previous file | base/threading/sequenced_worker_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698