Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/perf/benchmarks/system_health_unittest.py

Issue 2199333005: [tools/perf] Add unittests coverage for system health benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/system_health.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health_unittest.py
diff --git a/tools/perf/benchmarks/system_health_unittest.py b/tools/perf/benchmarks/system_health_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..9efdfc02eaa0142615856f1d9233f2bb4563f578
--- /dev/null
+++ b/tools/perf/benchmarks/system_health_unittest.py
@@ -0,0 +1,46 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import sys
+import unittest
+
+from benchmarks import system_health as system_health_benchmark
+from core import path_util
+from page_sets.system_health import system_health_stories
+
+from telemetry import benchmark as benchmark_module
+from telemetry.core import discover
+
+
+def _GetAllSystemHealthBenchmarks():
+ all_perf_benchmarks = discover.DiscoverClasses(
+ path_util.GetPerfBenchmarksDir(), path_util.GetPerfDir(),
+ benchmark_module.Benchmark,
+ index_by_class_name=True).values()
+ return [b for b in all_perf_benchmarks if
+ sys.modules[b.__module__] == system_health_benchmark]
+
+
+class TestSystemHealthBenchmarks(unittest.TestCase):
+
+ def testNamePrefix(self):
+ for b in _GetAllSystemHealthBenchmarks():
+ self.assertTrue(
+ b.Name().startswith('system_health.'),
+ '%r must have name starting with "system_health." prefix' % b)
+
+ def testShouldTearDownStateAfterEachStoryRunIsTrue(self):
+ for b in _GetAllSystemHealthBenchmarks():
+ self.assertTrue(
+ b.ShouldTearDownStateAfterEachStoryRun(),
+ '%r has ShouldTearDownStateAfterEachStoryRun set to False' % b)
+
+ def testSystemHealthStorySetIsUsed(self):
+ for b in _GetAllSystemHealthBenchmarks():
+ if b is system_health_benchmark.WebviewStartupSystemHealthBenchmark:
+ continue
+ self.assertIsInstance(
+ b().CreateStorySet(None),
+ system_health_stories.SystemHealthStorySet,
+ '%r does not use SystemHealthStorySet' % b)
« no previous file with comments | « tools/perf/benchmarks/system_health.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698