Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2199333005: [tools/perf] Add unittests coverage for system health benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/benchmark_unittest.py ('k') | tools/perf/benchmarks/system_health_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health.py
diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py
index a4f8dfb5aae17c5cc5c2212832cffa475312ea7e..2d80785a99da3ac35da7d034cc2eb86f70e8efc2 100644
--- a/tools/perf/benchmarks/system_health.py
+++ b/tools/perf/benchmarks/system_health.py
@@ -16,47 +16,6 @@ import page_sets
_IGNORED_STATS_RE = re.compile(r'_(std|count|max|min|sum|pct_\d{4}(_\d+)?)$')
-class _SystemHealthBenchmark(perf_benchmark.PerfBenchmark):
- TRACING_CATEGORIES = [
- 'benchmark',
- 'navigation',
- 'blink.user_timing',
- ]
-
- def CreateTimelineBasedMeasurementOptions(self):
- options = timeline_based_measurement.Options()
- options.config.chrome_trace_config.SetCategoryFilter(
- chrome_trace_category_filter.ChromeTraceCategoryFilter(','.join(
- self.TRACING_CATEGORIES)))
- options.SetTimelineBasedMetrics(['systemHealthMetrics'])
- return options
-
- @classmethod
- def ShouldDisable(cls, browser):
- # http://crbug.com/600463
- galaxy_s5_type_name = 'SM-G900H'
- return browser.platform.GetDeviceTypeName() == galaxy_s5_type_name
-
-
-@benchmark.Disabled('all') # crbug.com/613050
-class SystemHealthTop25(_SystemHealthBenchmark):
- page_set = page_sets.Top25PageSet
-
- @classmethod
- def Name(cls):
- return 'system_health.top25'
-
-
-@benchmark.Disabled('android') # crbug.com/601953
-@benchmark.Disabled('all') # crbug.com/613050
-class SystemHealthKeyMobileSites(_SystemHealthBenchmark):
- page_set = page_sets.KeyMobileSitesPageSet
-
- @classmethod
- def Name(cls):
- return 'system_health.key_mobile_sites'
-
-
class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):
"""Chrome Memory System Health Benchmark.
« no previous file with comments | « tools/perf/benchmarks/benchmark_unittest.py ('k') | tools/perf/benchmarks/system_health_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698